Stream: IG creation
Topic: ValueSet logical definition layout
Etienne Cantineau (May 05 2020 at 06:46):
In Logical Definition, when i have the sentence "This value set includes code based on the following rules: ", it always comes after the rules instead of before. I've checked in the layout but it seems it's not something i can modify myself.
Jose Costa Teixeira (May 05 2020 at 06:47):
can you show an example (repo or print screen)?
Etienne Cantineau (May 05 2020 at 06:53):
https://ec-ehealth.github.io/ehealthplatformstandards/ValueSet-be-allergyintolerancecode.html
Etienne Cantineau (May 05 2020 at 07:06):
And another thing in the layout, the expansion part has some issues with the additional languages. The display is only one language and it takes the display from the last one defined in the json file whatever the language it is.
Grahame Grieve (May 05 2020 at 07:15):
is the source for that available so I can run the publisher on it?
Etienne Cantineau (May 05 2020 at 07:26):
https://github.com/ec-ehealth/Build-source
Grahame Grieve (May 05 2020 at 07:40):
any reason not to use the ci-build?
Etienne Cantineau (May 05 2020 at 07:48):
Sorry i don't understand the question
Jose Costa Teixeira (May 05 2020 at 07:53):
Grahame is asking why is this repository not built using the CI-build - @Etienne Cantineau sorry, i did not inform of that before. Here are the steps if you want:
Jose Costa Teixeira (May 05 2020 at 07:54):
https://github.com/FHIR/auto-ig-builder
Jose Costa Teixeira (May 05 2020 at 10:40):
It's in the CI build now - thanks @Etienne Cantineau
Jose Costa Teixeira (May 05 2020 at 10:40):
Now there is an issue with the pubpack -
Jose Costa Teixeira (May 05 2020 at 10:40):
Grahame Grieve (May 05 2020 at 11:01):
the value set issue is fixed next bulid
Jose Costa Teixeira (May 05 2020 at 11:02):
Thank you!
Jose Costa Teixeira (May 06 2020 at 04:25):
http://build.fhir.org/ig/ec-ehealth/Build-source/branches/master/ValueSet-be-allergyintolerancecode.html#logical-definition-cld
@Etienne Cantineau issue fixed, today we should have the proper template
@Grahame Grieve thank you
Etienne Cantineau (May 06 2020 at 05:22):
Nice, thank you Jose
Jose Costa Teixeira (May 06 2020 at 07:50):
there is an issue with rendering emails in the footer:
http://build.fhir.org/ig/ec-ehealth/Build-source/branches/master/index.html
Jose Costa Teixeira (May 06 2020 at 07:51):
not sure if tis is publisher or template thing. it prefixes the email address with the path
Jose Costa Teixeira (May 06 2020 at 07:53):
link href points to this:
http://build.fhir.org/ig/ec-ehealth/Build-source/branches/master/etienne....@ehealth...
Grahame Grieve (May 06 2020 at 07:58):
which link is this?
Etienne Cantineau (May 06 2020 at 08:16):
The link "ehealth Platform", the issue is actually fixed by putting in the first contact of IGguide an url contact instead of an email contact.
With an email contact, it prefixes the value with "http://build.fhir.org/ig/ec-ehealth/Build-source/branches/master" and try to resolve it as a link generating erros in QA.
Grahame Grieve (May 06 2020 at 08:23):
that means that your email link is wrong - as a URL, it needs mailto: prefixed, and then that won't happen
Etienne Cantineau (May 06 2020 at 08:54):
The issue with the sentence is well fixed, will something for the additional languages in expansion be also done?
Grahame Grieve (May 06 2020 at 12:10):
well, you actually have to set up the server to do that, and/or provide translations
Grahame Grieve (May 06 2020 at 12:10):
it doesn't look like you've done that
Etienne Cantineau (May 06 2020 at 13:03):
Here i have 2 values with translations: http://build.fhir.org/ig/ec-ehealth/Build-source/branches/master/ValueSet-be-noallergy.html
The expansion displays only one value and it's the last one defined in json file.
Michael Lawley (May 06 2020 at 13:59):
That thing about mailto: doesn't seem right. This is ContactPoint right? in which case system tells you that it's of type email and value is string-typed with the definition text "...in a form that is meaningful to the designated communication system (i.e. phone number or email address)". Why would a URL format be expected?
Jose Costa Teixeira (May 06 2020 at 14:29):
that makes sense
Grahame Grieve (May 06 2020 at 19:54):
usually people either have the system wrong, or don't have the prefix. In this case, I couldn't see the problem on a quick look
Last updated: Apr 12 2022 at 19:14 UTC
