FHIR Chat · US Core profile link wrong · IG creation

Stream: IG creation

Topic: US Core profile link wrong

Sarah Gaunt (Jul 12 2021 at 22:05):

I have a dependency on the latest version of US Core:

<dependsOn id="hl7fhiruscore">
        <uri value="http://hl7.org/fhir/us/core/ImplementationGuide/hl7.fhir.us.core"/>
        <packageId value="hl7.fhir.us.core"/>
        <version value="4.0.0"/>
    </dependsOn>

This is creating links in the profiles that have a US Core base profile that appear to be wrong: http://build.fhir.org/ig/HL7/vr-common-library/StructureDefinition-Patient-mother.html (See the link at "This structure is derived from USCorePatientProfile).

Something is setting the link to: http://hl7.org/fhir/us/core/STU4.0.0/StructureDefinition-us-core-patient.html and it looks like the link should be: http://hl7.org/fhir/us/core/STU4/StructureDefinition-us-core-patient.html.

Another thing to note is that the IG Publisher is not picking up that the link is bad...

Is this something I can fix on my end (I guess I could change the version I'm depending on to current, but I don't think I really want to do that do I?)?

Sarah Gaunt (Jul 12 2021 at 22:42):

Actually will try to set the dependsOn version to just be 4 - not sure that's actually valid in terms of versions though....

Sarah Gaunt (Jul 12 2021 at 23:12):

Unfortunately that doesn't work - crashes with Publishing Content Failed: Unable to find package hl7.fhir.us.core#4

Sarah Gaunt (Jul 12 2021 at 23:47):

@Mark Iantorno I have created an issue for this here: https://github.com/HL7/fhir-ig-publisher/issues/295

Eric Haas (Jul 13 2021 at 03:47):

I erroneously set the package file to http://hl7.org/fhir/us/core/STU4.0.0 and Grahame fixed it prior to publishing. Obviously it had some other consequences because the package file

~/.fhir/packages/hl7.fhir.us.core#4.0.0/package/package.json

has this

{
  "name": "hl7.fhir.us.core",
  "version": "4.0.0",
  "tools-version": 3,
  "type": "fhir.ig",
  "date": "20210628190945",
  "license": "CC0-1.0",
  "canonical": "http://hl7.org/fhir/us/core",
  "url": "http://hl7.org/fhir/us/core/STU4.0.0",
  ...
}

Eric Haas (Jul 13 2021 at 04:03):

you can do a temporary work around this locally by editing this file

Sarah Gaunt (Jul 13 2021 at 07:06):

Ah... Thanks for the intel @Eric Haas . We're getting ready to publish a few (3) IGs that depend on US Core, so the local fix won't really help much.

Eric Haas (Jul 13 2021 at 15:23):

sorry for the error causing this delay

Sarah Gaunt (Jul 13 2021 at 20:00):

No delay yet - I'm sure we'll work something out before we publish!

Grahame Grieve (Jul 13 2021 at 20:12):

sigh. Publishing errors are really pernicious. This is really difficult to fix because the package is released, and wrong.

Grahame Grieve (Jul 13 2021 at 20:14):

@Mark Iantorno you can work around this in /org.hl7.fhir.utilities/src/main/java/org/hl7/fhir/utilities/npm/PackageHacker.java in fixPackageUrl

Sarah Gaunt (Jul 13 2021 at 20:43):

BTW - the IG publisher didn't catch that the links were broken, was just a fluke that I found them. (I've added that to the ticket so hopefully it can be changed to pick them up in the future.)

Sarah Gaunt (Jul 13 2021 at 22:23):

Is this Warning the same issue: [Unable to determine whether the provided codes are in the value set http://hl7.org/fhir/us/core/ValueSet/us-core-vital-signs because the value set or code system is not known to the validator]?

If you try to go to http://hl7.org/fhir/us/core/ValueSet/us-core-vital-signs it re-directs to: http://hl7.org/fhir/us/core/STU4.0.0/ValueSet-us-core-vital-signs.html...

Lloyd McKenzie (Jul 13 2021 at 22:24):

Hitting the same issue with the SDOH-CC IG. We have hyperlinks in the CapabilityStatement that are driven by the canonical URL. The canonical URL is redirecting, but there's nothing at the location it redirects to.

Sarah Gaunt (Jul 13 2021 at 22:26):

If the vital signs value set re-directed to http://hl7.org/fhir/us/core/STU4/ValueSet-us-core-vital-signs.html it would work, I think.

Mark Iantorno (Jul 14 2021 at 13:45):

Looking at this now

Mark Iantorno (Jul 14 2021 at 14:07):

@Sarah Gaunt if I wanted to test this, what would be the quickest way to see if my fix works?

Mark Iantorno (Jul 14 2021 at 14:36):

(deleted)

Mark Iantorno (Jul 14 2021 at 14:36):

nm answered my own question

Mark Iantorno (Jul 14 2021 at 14:41):

I still would like to know how to test it though @Sarah Gaunt

Mark Iantorno (Jul 14 2021 at 14:41):

PR is here: https://github.com/hapifhir/org.hl7.fhir.core/pull/560

Sarah Gaunt (Jul 14 2021 at 20:33):

@Mark Iantorno Re-build HL7 / vr-common-library from here: https://fhir.github.io/auto-ig-builder/builds.html, then go to http://build.fhir.org/ig/HL7/vr-common-library/StructureDefinition-Patient-mother.html, find "This structure is derived from USCorePatientProfile" and make sure the link works.

Sarah Gaunt (Jul 14 2021 at 20:34):

I'm rebuilding now - not sure if you've fixed or not, but will test...

Sarah Gaunt (Jul 14 2021 at 20:35):

Or I guess, build that IG locally and check same.

Mark Iantorno (Jul 15 2021 at 12:15):

I did not merge the PR yet

Mark Iantorno (Jul 15 2021 at 12:15):

I would have to check locally

Mark Iantorno (Jul 19 2021 at 13:52):

Hey @Sarah Gaunt can you please try the latest release of the IG-publisher

Mark Iantorno (Jul 19 2021 at 13:52):

https://github.com/HL7/fhir-ig-publisher/releases/tag/1.1.77

Mark Iantorno (Jul 19 2021 at 13:52):

let me know if that solves your issue

Mark Iantorno (Jul 19 2021 at 13:52):

it contains the fix from the core libraries that I put in tlast week

Sarah Gaunt (Jul 19 2021 at 19:27):

Thanks @Mark Iantorno I just re-built and still getting the "4.0.0" instead of "4" in the url: http://hl7.org/fhir/us/core/STU4.0.0/StructureDefinition-us-core-encounter.html. (see http://build.fhir.org/ig/HL7/fhir-bfdr/branches/master/StructureDefinition-Encounter-birth.html).

Sarah Gaunt (Jul 21 2021 at 14:51):

Any further updates on this @Mark Iantorno ?

Mark Iantorno (Jul 21 2021 at 16:39):

I had a fix in , and I couldn't build because the terminology server was down. Now that it is back working again, I will try and push out the change

Mark Iantorno (Jul 21 2021 at 16:39):

Sorry for the delay

Sarah Gaunt (Jul 21 2021 at 18:55):

No worries, just didn't want it to fall off the radar! And I didn't actually realize you couldn't build either with the tx server being down...

Mark Iantorno (Jul 23 2021 at 18:08):

Okay, so reviewing this again, I'm not sure why this is still not working for you. I released 1.1.77 (https://github.com/HL7/fhir-ig-publisher/releases/tag/1.1.77) with the changed from the core (specifically https://github.com/hapifhir/org.hl7.fhir.core/pull/560/files).

Mark Iantorno (Jul 23 2021 at 18:08):

I check for the url fragment

    if (webref.contains("hl7.org/fhir/us/core/STU4.0.0")) {
      webref.replace("hl7.org/fhir/us/core/STU4.0.0", "hl7.org/fhir/us/core/STU4");
    }`

Mark Iantorno (Jul 23 2021 at 18:10):

@Grahame Grieve is there any other place other than the PackageHacker that I need to check for this?

Eric Haas (Jul 23 2021 at 18:57):

I the downloaded package file today and it still has hl7.org/fhir/us/core/STU4.0.0 in package.json:

{
  "name": "hl7.fhir.us.core",
  "version": "4.0.0",
  "tools-version": 3,
  "type": "fhir.ig",
  "date": "20210628190945",
  "license": "CC0-1.0",
  "canonical": "http://hl7.org/fhir/us/core",
  "url": "http://hl7.org/fhir/us/core/STU4.0.0", //<<<<<<< still here
  "title": "US Core Implementation Guide",
  //..
}

Lloyd McKenzie (Jul 23 2021 at 19:56):

I think that's an @Lynn Laakso issue?

Mark Iantorno (Jul 26 2021 at 14:13):

@Lynn Laakso can we have a quick call at some point today, if you are available. I have most of the permissions to do commits and publish, I just need clarification on exactly what needs to be done.

Mark Iantorno (Jul 26 2021 at 14:14):

I would prefer to get this done soon, as I know @Sarah Gaunt has been waiting on this.

Lynn Laakso (Jul 26 2021 at 14:14):

@Mark Iantorno just back from medical time off, DM me for scheduling

Sarah Gaunt (Jul 26 2021 at 21:02):

We won't have approval to publish the affected IGs for a couple of weeks (still have to go through FMG and TSC), so it's not a huge rush - just needs to be fixed before we actually publish.

Sarah Gaunt (Jul 26 2021 at 21:05):

Also - I will re-build again now - I am not sure if you made another change after the terminology server issues. I haven't tested since then...

Sarah Gaunt (Jul 26 2021 at 21:33):

Yes, still broken - must be the package.json file that Eric mentioned.

Sarah Gaunt (Aug 19 2021 at 04:38):

@Grahame Grieve don't want to hassle you too much though I suspect there was no easing back into work for you... Could you take a look at this issue sometime in the near future as we have a few IGs that are being held up from publication because we can't publish with the broken US Core links.

Grahame Grieve (Aug 19 2021 at 05:00):

so I thought this was fixed. How to reproduce?

Sarah Gaunt (Aug 19 2021 at 05:17):

Build any IG that bases a profile on a US Core profile. Like here: http://build.fhir.org/ig/HL7/case-reporting/branches/master/StructureDefinition-us-ph-patient.html
Click on the link for the US Core Patient and it uses http://hl7.org/fhir/us/core/STU4.0.0/StructureDefinition-us-core-patient.html
It should be: http://hl7.org/fhir/us/core/STU4/StructureDefinition-us-core-patient.html

It's not just the base profile links either, I think it's anything from US Core - like if you click on the US Core Ethnicity extension link in that same profile I linked above, you'll get the same problem.

Sarah Gaunt (Aug 19 2021 at 05:32):

And now I'm super confused, because I look at an IG that just went to ballot and it doesn't have the issue: http://hl7.org/fhir/us/cancer-reporting/2021Sep/StructureDefinition-us-pathology-related-practitioner-role.html

So maybe it's something I'm doing wrong?

Sarah Gaunt (Aug 19 2021 at 05:38):

Though, that same profile in the ci build has the issue, so maybe Lynn etc. manually fixed the issue before ballot... https://build.fhir.org/ig/HL7/cancer-reporting/StructureDefinition-us-pathology-related-practitioner-role.html

Lynn Laakso (Aug 19 2021 at 12:35):

It was fixed after publication, note the link in cancer-reporting goes to us/core/STU4 but your IG is still picking up a reference to us/core/STU4.0.0. There's somewhere that didn't get fixed.

Sarah Gaunt (Aug 19 2021 at 21:08):

I just rebuilt the Cancer IG in the CI Build and it's still picking up the 4.0.0 reference - maybe was just fixed for the ballot publications?

Grahame Grieve (Aug 19 2021 at 22:30):

fixed next release

Sarah Gaunt (Aug 26 2021 at 20:00):

Do we have an ETA on the next release?

Grahame Grieve (Aug 26 2021 at 20:38):

sometime soon. maybe today or tomorrow

Last updated: Apr 12 2022 at 19:14 UTC