Stream: IG creation
Topic: US Core QA Issue #4- bad link for rel ref in bundle
Eric Haas (Jul 03 2020 at 19:42):
for the example search bundle instance : https://build.fhir.org/ig/HL7/US-Core-R4/Bundle-c887e62f-6166-419f-8268-b5ecd6c7b901.html
source file here: https://github.com/HL7/US-Core-R4/blob/master/source/examples/allergyintolerance-provenance-example.json
I am getting this bad link error...
The link 'AllergyIntolerance/79613' for "AllergyIntolerance/79613" cannot be resolved
I double checked the rules for resolving references in bundles reference using the bundle example in the base spec and I can't see what is wrong ...here is a snippet...
resourceType: Bundle
id: c887e62f-6166-419f-8268-b5ecd6c7b901
meta:
lastUpdated: '2019-07-09T18:49:01.235+00:00'
type: searchset
total: 1
link:
- relation: self
url: >-
http://example.org/fhir/AllergyIntolerance?_revinclude=Provenance%3Atarget&patient=Examples
entry:
- fullUrl: 'http://example.org/fhir/AllergyIntolerance/79613' # <-----referenced resource here
resource:
resourceType: AllergyIntolerance
id: '79613'
...
- fullUrl: 'http://example.org/fhir/Provenance/79614'
resource:
resourceType: Provenance
id: '79614'
...
target:
- reference: AllergyIntolerance/79613 #<--- link to resource in bundle
recorded: '2019-07-09T15:26:23.217+00:00'
....
Grahame Grieve (Jul 03 2020 at 20:52):
looks like it should be right
Eric Haas (Jul 03 2020 at 20:56):
I will run in my test ig and see...
Eric Haas (Jul 03 2020 at 21:46):
Oddly I can run this example and no link errors
But my example above which I revalidated has the above link error as does this contained reference for this file:
resourceType: MedicationRequest
id: uscore-mo2
meta:
profile:
- 'http://hl7.org/fhir/us/core/StructureDefinition/us-core-medicationrequest'
contained:
- resourceType: Medication
id: med2 #<----
code:
coding:
- system: 'http://www.nlm.nih.gov/research/umls/rxnorm'
code: '582620'
display: 'Nizatidine 15 MG/ML Oral Solution [Axid]'
text: 'Nizatidine 15 MG/ML Oral Solution [Axid]'
status: active
intent: order
medicationReference:
reference: '#med2' #<-----
display: 'Nizatidine 15 MG/ML Oral Solution [Axid]'
subject:
reference: Patient/example
display: Amy Shaw
authoredOn: '2008-04-05'
requester:
reference: Practitioner/practitioner-1
display: 'Ronald Bone, MD'
dosageInstruction:
- text: 10 mL bid
timing:
repeat:
boundsPeriod:
start: '2008-04-05'
dispenseRequest:
numberOfRepeatsAllowed: 1
quantity:
value: 480
unit: mL
system: 'http://unitsofmeasure.org'
code: mL
expectedSupplyDuration:
value: 30
unit: days
system: 'http://unitsofmeasure.org'
code: d
which give the following error:
The link '#med2' for "Nizatidine 15 MG/ML Oral Solution [Axid]. Generated Summary: unknown resource contained" cannot be resolved (valid targets: [ig-status, segment-header, publish-box, root, stripe, segment-footer, segment-post-footer, segment-navbar, segment-content, segment-breadcrumb])
Michaela Ziegler (Jul 09 2020 at 07:39):
@Eric Haas Do you still have this error message, or how did you solve it/what is the reason?
Eric Haas (Jul 09 2020 at 22:52):
I will need to run again in isolation to see. will ping you after.
Eric Haas (Jul 12 2020 at 22:39):
Yes I am still getting bad links for contained references even though there is no corresponding error in the example resource itself.
Here is the repro: https://github.com/Healthedata1/IG-Template4/tree/color-highlighting
the qa file is here: https://github.com/Healthedata1/IG-Template4/blob/color-highlighting/docs/qa.txt
Eric Haas (Jul 12 2020 at 22:39):
I did not recheck the bundle example.
Grahame Grieve (Jul 13 2020 at 23:31):
so when I try to clone that repo to a new folder:
git.exe clone --progress -v "https://github.com/Healthedata1/IG-Template4" "C:\work\org.hl7.fhir.igs\IG-Template4"
Cloning into 'C:\work\org.hl7.fhir.igs\IG-Template4'...
POST git-upload-pack (152 bytes)
POST git-upload-pack (490 bytes)
remote: Enumerating objects: 5484, done.
remote: Counting objects: 100% (5484/5484), done.
remote: Compressing objects: 100% (2107/2107), done.
remote: Total 28998 (delta 4522), reused 4123 (delta 3312), pack-reused 23514
Receiving objects: 100% (28998/28998), 85.58 MiB | 3.09 MiB/s, done.
Resolving deltas: 100% (25047/25047), done.
error: invalid path 'my notes/201810:29-build notes'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
git did not exit cleanly (exit code 128) (33453 ms @ 14/07/2020 9:31:17 AM)
Eric Haas (Jul 14 2020 at 02:19):
OK I cleaned up the folder and should work for you now. Note that the error is reproduced in the 'color-highlighting' branch
Grahame Grieve (Jul 16 2020 at 06:50):
I still get error: invalid path 'my notes/201810:29-build notes'
Grahame Grieve (Jul 16 2020 at 06:51):
you can't commit a file with : in the name
Eric Haas (Jul 16 2020 at 20:31):
OK I removed all the my_notes folders from all the branches in the repro. so I hope is not a problem anymore
Grahame Grieve (Jul 17 2020 at 03:38):
ok fixed next release
Eric Haas (Jul 21 2020 at 21:07):
yes that fixed the contained references but still getting a bad link error to a bundle entry for a search bundle examples for provenance target referencing the other resource in the Bundle.
Bundle-example1.html#/html/body/div/div/div/div/div/div/blockquote/p/a at Line 196, column 517 error The link 'Procedure/1153' for "Procedure/1153" cannot be resolved
It can be reproduced in the the same repro as above but in the "add-tabs branch": https://github.com/Healthedata1/IG-Template4/tree/add-tabs
for this example: https://github.com/Healthedata1/IG-Template4/blob/add-tabs/input/examples/bundle-example1.json
Grahame Grieve (Jul 21 2020 at 22:14):
error: invalid path 'my_notes/201810:29-build notes'
Eric Haas (Jul 21 2020 at 22:21):
sorry removed the folder from that branch too.
Eric Haas (Jul 29 2020 at 15:19):
This error popped up again. a relative link in the generated narrative for a bundle entry is causing a bad link error....
Eric Haas (Jul 29 2020 at 15:19):
here is the generated output that is leading to the link error...
Grahame Grieve (Jul 29 2020 at 19:56):
how do I reproduce this?
Eric Haas (Jul 29 2020 at 20:20):
I will create a test case and let you know
Eric Haas (Jul 30 2020 at 20:30):
this repro : https://github.com/Healthedata1/IG-Template4/tree/add-tabs
has this example
Grahame Grieve (Jul 31 2020 at 06:26):
ok fixed
Last updated: Apr 12 2022 at 19:14 UTC