FHIR Chat · US Core Link invalid · IG creation

Stream: IG creation

Topic: US Core Link invalid


view this post on Zulip Nagesh Bashyam (Dec 16 2019 at 19:45):

Hello
I have a dependency on US Core and the dependency is working when i create profiles and such. However whenever I refer to US Core using the following Link it comes up as Invalid in the QA Report, Any idea on what may be going on ?

The link 'http://hl7.org/fhir/us/core/STU3' for "US Core - R4 version" cannot be resolved
Should i use the complete URI as present in the Dependencies below to avoid the error ?

Any thoughts would be appreciated ..

<dependsOn>
<uri value="http://hl7.org/fhir/us/core/ImplementationGuide/hl7.fhir.us.core"/>
<packageId value="hl7.fhir.us.core"/>
<version value="3.1.0"/>
</dependsOn>

view this post on Zulip Grahame Grieve (Dec 16 2019 at 19:52):

I would have expected:

<dependsOn>
  <uri value="http://hl7.org/fhir/us/core"/>
  <packageId value="hl7.fhir.us.core"/>
  <version value="3.1.0"/>
</dependsOn>

view this post on Zulip Nagesh Bashyam (Dec 17 2019 at 03:39):

If I use the above dependency as suggested, I get an Exception as below

org.hl7.fhir.exceptions.FHIRException: Unable to understand IG url: http://hl7.org/fhir/us/core
at org.hl7.fhir.igtools.publisher.Publisher.determineCanonical(Publisher.java:1540)
at org.hl7.fhir.igtools.publisher.Publisher.loadIg(Publisher.java:2213)
at org.hl7.fhir.igtools.publisher.Publisher.initializeFromIg(Publisher.java:1475)
at org.hl7.fhir.igtools.publisher.Publisher.initialize(Publisher.java:1168)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:650)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:6661)

@Eric Haas had provided the above dependency solution which works..but my absolute links
'http://hl7.org/fhir/us/core/STU3' show up as Error in the build log but the link itself resolves.

view this post on Zulip Grahame Grieve (Dec 17 2019 at 03:54):

ahh. technically, you depend on the IG resource itself, so your reference needs to be : http://hl7.org/fhir/us/core/ImplementationGuide/hl7.fhir.us.core

view this post on Zulip Nagesh Bashyam (Dec 17 2019 at 03:57):

So that works and the links when i navigate on the Browser works.
For e.g when I derive from the US Core Patient, it is recognized and the profile renders.

However the build QA output has the following error:
The link 'http://hl7.org/fhir/us/core/STU3.1/StructureDefinition-us-core-patient.html' for "USCorePatientProfile" cannot be resolved

There are many errors like this all of which point back to USCore, which it says it does not recognize, cannot resolve etc.

Trying to figure out what the tool does not like ..

view this post on Zulip Grahame Grieve (Dec 17 2019 at 03:58):

which IG is this? I'm about to go out but I'll have a look later tonight

view this post on Zulip Nagesh Bashyam (Dec 17 2019 at 03:59):

QA Output : http://build.fhir.org/ig/HL7/davinci-atr/branches/master/qa.html
GitHub Location: https://github.com/hl7/davinci-atr

Everything is checked in, by the way I am using the new templates, dont know if that matters.
The dependency is present in davinci-atr.xml

view this post on Zulip Eric Haas (Dec 17 2019 at 14:28):

I have US Core dependency for Da Vinci Notifications using the old ig.json approach:

  "dependencyList": [
    {
      "name": "uscore",
      "package": "hl7.fhir.us.core",
      "version": "3.1.0",
      "location": "http://hl7.org/fhir/us/core"
    },
    {
      "name": "hrex",
      "package": "hl7.fhir.us.davinci-hrex",
      "version": "0.1.0",
      "location": "http://hl7.org/fhir/us/davinci-hrex"
    }
  ],

which corresponds to the Implementation Guide resource as :

  <!-- insert dependency -->
  <dependsOn id="hrex">
    <!-- 0..* Another Implementation guide this depends on -->
    <uri value="http://hl7.org/fhir/us/davinci-hrex">
      <!-- 1..1 canonical(ImplementationGuide) Identity of the IG that this depends on -->
    </uri>
    <packageId value="hl7.fhir.us.davinci-hrex"/>
    <!-- 0..1 NPM Package name for IG this depends on -->
    <version value="0.1.0"/><!-- 0..1 Version of the IG --></dependsOn>
  <dependsOn id="uscore">
    <!-- 0..* Another Implementation guide this depends on -->
    <uri value="http://hl7.org/fhir/us/core">
      <!-- 1..1 canonical(ImplementationGuide) Identity of the IG that this depends on -->
    </uri>
    <packageId value="hl7.fhir.us.core"/>
    <!-- 0..1 NPM Package name for IG this depends on -->
    <version value="3.1.0"/><!-- 0..1 Version of the IG --></dependsOn>

view this post on Zulip Eric Haas (Dec 17 2019 at 14:29):

last time I checked this worked for me..,

view this post on Zulip Nagesh Bashyam (Dec 17 2019 at 14:32):

The dependencies work, but the Build has unresolved link errors but they all resolve.

view this post on Zulip Eric Haas (Dec 17 2019 at 14:36):

no errors for me, let me clone yours and run and see.....

view this post on Zulip Nagesh Bashyam (Dec 17 2019 at 14:37):

If I use the Id maybe it will go away... I could use {{site.data.fhir.uscore}}/index.html ..correct ?

view this post on Zulip Nagesh Bashyam (Dec 17 2019 at 14:51):

After I used the id now that eliminated a whole bunch of errors. I will check in that fix and get the errors reduced before i address the next batch. I will have to do the same in profile of profiles i think..where i see the same issues with uscore references.

view this post on Zulip Eric Haas (Dec 17 2019 at 16:22):

Here is what I get with the templates build...

Error checking links for hl7.fhir.us.core#3.0.0: null
Error checking links for hl7.fhir.us.core#3.1.0: null
  ... 638 html files, 0 pages invalid xhtml (0%)                                 (02:22.0534)
  ... 201906 links, 375 broken links (0%)

view this post on Zulip Eric Haas (Dec 17 2019 at 16:23):

this is before I made any changes.

view this post on Zulip Eric Haas (Dec 17 2019 at 16:34):

ooops on the above IG resource, I need to update the uris to IGs.

view this post on Zulip Eric Haas (Dec 17 2019 at 16:36):

(deleted)

view this post on Zulip Eric Haas (Dec 17 2019 at 17:32):

I don't have a clue.. I have yet to wrangle and tame the templates approach... sorry.

view this post on Zulip Grahame Grieve (Dec 17 2019 at 20:33):

@Nagesh Bashyam I am still debugging to make sure this kind of thing has a clear answer.. but which are you trying to refer to? STU3 or STU3.1? Because that's the immediate source of your problems

view this post on Zulip Nagesh Bashyam (Dec 17 2019 at 20:55):

3.1
The dependency has only 3.1.0 in it..
How does 3.0 come into picutre ?

view this post on Zulip Eric Haas (Dec 17 2019 at 21:39):

the build reports an error that it can't find 3.0.0 ( see above )

view this post on Zulip Grahame Grieve (Dec 18 2019 at 00:23):

How does 3.0 come into picutre ?

In the menu, you have hard coded links to 3.0.0 not 3.1.0

view this post on Zulip Grahame Grieve (Dec 18 2019 at 00:29):

ok so I will update your source, and the IG publisher, leaving you to fix:

  • you have broken links in the narrative
  • you are adding a link to a downloadable schematron, but the path in the link is wrong

view this post on Zulip Nagesh Bashyam (Dec 18 2019 at 04:23):

Thanks @Grahame Grieve , the change is awesome ..almost all of the US Core bad links are resolved.
I will work on the rest, there are few that are because of the new template which will get resolved soon.


Last updated: Apr 12 2022 at 19:14 UTC