Stream: IG creation
Topic: Rendering List examples - seems inconsistent
Rob Eastwood (Feb 06 2022 at 23:05):
Hello,
We have noticed that List instances have an IG Publisher generated narrative that differs from other resource type instances. For instance
- extensions are not displayed
- different elements run onto the same line
- element names are not enboldened.
To demonstrate:
- this R4 List example was copied into a fresh IG (1) and removed the hand-crafted narrative - see rendering here, and screen shot below
- a simple List example with a core spec List extension - see rendering here
I am trying to track down whether this is an issue in the examples, or something upstream like the template or publisher. Any suggestions?
(1) Notes on demo IG
- adapted using FHIR/sample-ig
- standard template fhir.base.template#current
- IG Publisher v1.1.99
Grahame Grieve (Feb 07 2022 at 20:45):
it's not different to other resources. Some resources do not have a custom renderer, and so they render based on the underlying definitions. Others have a custom renderer that picks up the extensions it knows about. The code you're interested in is https://github.com/hapifhir/org.hl7.fhir.core/blob/master/org.hl7.fhir.r5/src/main/java/org/hl7/fhir/r5/renderers/ListRenderer.java
Rob Eastwood (Feb 08 2022 at 00:45):
Thanks @Grahame Grieve - as I have no java skills to submit a PR, I'll add a Github issue to that repository (to the effect that the List resource needs a custom renderer - is that what you are getting at??)
Grahame Grieve (Feb 08 2022 at 00:49):
it has a custom renderer. You just don't like how it works. So you can propose the changes you think should happen
Rob Eastwood (Feb 08 2022 at 01:04):
Gottcha - thanks muchly @Grahame Grieve
Last updated: Apr 12 2022 at 19:14 UTC
