Stream: IG creation
Topic: Relative link bug?
Max Masnick (Nov 02 2020 at 19:33):
Hi -- I am trying to figure out what part IG publishing workflow is responsible for what I think is a bug.
I am adding a relative link in the Description field of a StructureDefintion implemented in FSH (view on GitHub:
Profile: MCODEPatientBundle
Parent: Bundle
Id: mcode-patient-bundle
Title: "mCODE Patient Bundle"
Description: "A collection of data for an mCODE cancer patient. [See details here](mcode-patient-bundle.html)."
This link appears as a relative link on artifacts.html:
<a href="mcode-patient-bundle.html">See details here</a>
However, on the StructureDefinition page, the link is converted to an absolute link to http://hl7.org/fhir/R4/:
<tr><td>Definition:</td><td><p><a name="8c170834-61ce-429b-99b2-d3dbf6558d9a"></a>A collection of data for an mCODE cancer patient. <a href="http://hl7.org/fhir/R4/mcode-patient-bundle.html">See details here</a>.</p>
</td></tr>
I believe the expected behavior here is a relative link (<a href="mcode-patient-bundle.html">See details here</a>) on all pages where this appears in the built IG.
I looked at the JSON generated by SUSHI, and it appears the Markdown link is being passed to the IG Publisher correctly:
fsh-generated/resources/StructureDefinition-mcode-patient-bundle.json:
17 "title": "mCODE Patient Bundle",
18 "status": "active",
19: "description": "A collection of data for an mCODE cancer patient. [See details here](mcode-patient-bundle.html).",
@Grahame Grieve Does this indicate a bug with the IG Publisher? If so, does this need an issue on GitHub? If not, what else could be the culprit?
Grahame Grieve (Nov 02 2020 at 20:35):
I'll have to debug. I don't know why it would be interpreting the context of the link as the base specification
Max Masnick (Nov 02 2020 at 22:23):
Thanks, please let me know if you need any additional information to reproduce this.
Grahame Grieve (Nov 05 2020 at 00:57):
this doesn't happen for me. I get:
Grahame Grieve (Nov 05 2020 at 00:58):
<td>
<p>A collection of data for an mCODE cancer patient. <a href="mcode-patient-bundle.html">See details here</a>.</p>
</td>
Max Masnick (Nov 05 2020 at 12:17):
@Grahame Grieve I reproduced this with a completely fresh clone of the mCODE git repo and the most up-to-date publisher. The full dump from my terminal showing this is here: https://gist.github.com/masnick/da69d3dd925ff012214553b181124e2f
The key line showing the repro (at the very bottom):
$ cat output/StructureDefinition-mcode-patient-bundle.html | grep http://hl7.org/fhir/R4/mcode-patient-bundle.html
<tr><td>Definition:</td><td><p><a name="d8c1570f-1bec-486e-a44a-7c51d63774b6"></a>A collection of data for an mCODE cancer patient. <a href="http://hl7.org/fhir/R4/mcode-patient-bundle.html">See details here</a>.</p>
The CI build is also reproducing this, at least as of Monday. I believe @Mark Kramer also saw this happen on his Windows computer.
Max Masnick (Nov 10 2020 at 10:40):
@Grahame Grieve any luck reproducing this? We have some changes we want to merge into the mCODE IG that depend on these relative links working.
Max Masnick (Nov 20 2020 at 12:44):
@Grahame Grieve sorry to bug you again...have you had any luck reproducing/fixing this?
Max Masnick (Nov 25 2020 at 20:04):
@Grahame Grieve this appears to be resolved with the latest publisher. Thanks!
Last updated: Apr 12 2022 at 19:14 UTC
