Stream: IG creation
Topic: QA on Hot-Beverages
Lloyd McKenzie (Apr 01 2022 at 14:07):
I noticed that the 'copy' icon for canonical URL and version isn't working in this IG. Is it derived from 'base'? Also, there's an extra 'external' link in the list of versions.
John Moehrke (Apr 01 2022 at 14:09):
yes it is derived off of base https://github.com/DavidPyke/HotBeverage
John Moehrke (Apr 01 2022 at 14:10):
internal template with a package.json
{
"name": "fhir.hotbeverage.template",
"type": "fhir.template",
"license": "CC0-1.0",
"description": "HotBeverage IG Template",
"author": "http://example.org/",
"canonical": "https://github.com/DavidPyke/ig-template-carequality",
"version": "current",
"base": "fhir.base.template",
"dependencies": {
"fhir.base.template": "current"
}
}
John Moehrke (Apr 01 2022 at 14:11):
the copy seemed to work for me
John Moehrke (Apr 01 2022 at 14:12):
ah, it functions, but is not displayed properly
Gino Canessa (Apr 01 2022 at 14:13):
Poor form John - I know you consider this a joke because it is in JSON instead of XML ;-)
Lloyd McKenzie (Apr 01 2022 at 14:14):
It's not that it doesn't work, it's that the right icon isn't shown and the hide/appear functionality doesn't work. With hot-bev, I see image.png - which shows up all the time, whereas I should see something like image.png which only shows up when I hover.
Lloyd McKenzie (Apr 01 2022 at 14:15):
Even April Fool jokes need to meet QA for publication ;)
John Moehrke (Apr 01 2022 at 14:15):
The extra link at the end of the status bar seems to be happening to HL7 stuff too -- http://hl7.org/fhir/us/qicore/STU4.1.1/
John Moehrke (Apr 01 2022 at 14:15):
Lloyd McKenzie said:
Even April Fool jokes need to meet QA for publication ;)
Our part meets QA. -- we have a perfect QA report -- http://fhir.org/guides/acme/HotBeverage/1.4.2022/qa.html
Lloyd McKenzie (Apr 01 2022 at 14:16):
qicore looks fine to me. Correct icon and hover reveals, non-hover hides
Lloyd McKenzie (Apr 01 2022 at 14:16):
QA isn't just the report...
John Moehrke (Apr 01 2022 at 14:16):
I will add... with ZERO suppressed warnings
Lloyd McKenzie (Apr 01 2022 at 14:16):
So you're saying that qicore for you looks like the first image?
John Moehrke (Apr 01 2022 at 14:16):
Lloyd McKenzie said:
qicore looks fine to me. Correct icon and hover reveals, non-hover hides
okay, than I don't understand your extra external link comment
John Moehrke (Apr 01 2022 at 14:17):
Lloyd McKenzie said:
So you're saying that qicore for you looks like the first image?
no, it looks okay on the copy-canonical topic... I was mentioning the second external link
Lloyd McKenzie (Apr 01 2022 at 14:17):
Do you see the difference in the icon between my two pictures?
John Moehrke (Apr 01 2022 at 14:17):
yes
John Moehrke (Apr 01 2022 at 14:17):
clearly the person responsible for templates needs to fix something
Lloyd McKenzie (Apr 01 2022 at 14:17):
ah, yes. The second external link is probably a problem everywhere. I think that's an @Grahame Grieve issue
John Moehrke (Apr 01 2022 at 14:18):
right, i think we have mentioned it at other times
Lloyd McKenzie (Apr 01 2022 at 14:19):
I'm more concerned about the copy icon. Somehow you broke it. I'm wondering how :)
John Moehrke (Apr 01 2022 at 14:20):
hmm, I don't know.. @David Pyke did the template customization.
John Moehrke (Apr 01 2022 at 14:22):
My customized IG seems to show the copy graphic -- http://build.fhir.org/ig/JohnMoehrke/NorwayAudit/
John Moehrke (Apr 01 2022 at 14:22):
also a nice Norway flag
John Moehrke (Apr 01 2022 at 14:24):
oh, my norway one is simply basic
John Moehrke (Apr 01 2022 at 14:26):
I do have one that I made a local template that shows the copy icon-- when you hover over it... but I don't want to put that link here.
John Moehrke (Apr 01 2022 at 14:28):
Gino Canessa said:
Poor form John - I know you consider this a joke because it is in JSON instead of XML ;-)
what?
Gino Canessa (Apr 01 2022 at 14:37):
Was quickly catching up and saw you posed a json snippet... sadly, now I see that it is package.json.
John Moehrke (Apr 01 2022 at 14:43):
whew
Gino Canessa (Apr 01 2022 at 14:45):
David Pyke (Apr 01 2022 at 15:24):
The template customizations are checked into the HotBeverage github for those who wish to marvel at my breakage of the template
Grahame Grieve (Apr 01 2022 at 20:11):
so no one got to the bottom of this?
Lloyd McKenzie (Apr 01 2022 at 22:13):
I haven't had a chance to dig on the CSS side of things with the icon. I think the double 'external' link is your issue.
Grahame Grieve (Apr 01 2022 at 22:14):
the double link is a challenge for me, but yes, my challenge
John Moehrke (Apr 01 2022 at 22:15):
I am so glad that an April Fools joke can bring about positive quality improvements.
John Moehrke (Apr 01 2022 at 22:16):
I should have put into that joke IG a need to slice on an extension that is in a slice, so that I could get that one figured out.
Last updated: Apr 12 2022 at 19:14 UTC
