Stream: IG creation
Topic: Publisher is unhappy
Lloyd McKenzie (Dec 04 2020 at 03:24):
Getting this on the CI build and locally:
[java] Error: Could not find or load main class org.hl7.fhir.igtools.publisher.Publisher
Lloyd McKenzie (Dec 04 2020 at 03:24):
@Grahame Grieve @Mark Iantorno
Grahame Grieve (Dec 04 2020 at 03:32):
@Mark Iantorno the class org.hl7.fhir.igtools.publisher.Publisher is in the jar. I don't know why it would give this error
Mark Iantorno (Dec 04 2020 at 03:34):
This is happening in the current build?
Mark Iantorno (Dec 04 2020 at 03:34):
The latest?
Mark Iantorno (Dec 04 2020 at 03:34):
@Lloyd McKenzie when you download the cli jar from the GitHub release you run it and get this error?
Mark Iantorno (Dec 04 2020 at 03:35):
Nothing I changed should cause this?
Mark Iantorno (Dec 04 2020 at 03:35):
@Lloyd McKenzie let me know exactly how you reproduced this
Grahame Grieve (Dec 04 2020 at 03:36):
I get the same error too
Elliot Silver (Dec 04 2020 at 03:36):
I ran ./_updatePublisher.sh and started getting it.
Grahame Grieve (Dec 04 2020 at 03:36):
at least, I get the same error if you use the current jar
Mark Iantorno (Dec 04 2020 at 03:38):
Let me look
Mark Iantorno (Dec 04 2020 at 03:47):
I just did a clean local build of 1.1.46, specifically this commit (https://github.com/HL7/fhir-ig-publisher/commit/500fc027b11856456a867e04904f19028f5326a7), and it didn't work either. However, when I checked out the previous release (https://github.com/HL7/fhir-ig-publisher/commit/5bca40d839f61ecc2c0b21150e83644866e9b716), it does work.
Grahame Grieve (Dec 04 2020 at 03:48):
so it's jgit?
Mark Iantorno (Dec 04 2020 at 03:48):
gimmy one sec
Mark Iantorno (Dec 04 2020 at 03:49):
I'm going to look real close at this commit (https://github.com/HL7/fhir-ig-publisher/commit/500fc027b11856456a867e04904f19028f5326a7) and dump the dependency graph to see what's up
Grahame Grieve (Dec 04 2020 at 03:50):
one would think that only the POM changes could result in the main java class not loading
Mark Iantorno (Dec 04 2020 at 03:52):
that would make the most sense, but I just want to be sure
Mark Iantorno (Dec 04 2020 at 03:53):
huh it was the jgit dependency
Mark Iantorno (Dec 04 2020 at 03:53):
but why
Mark Iantorno (Dec 04 2020 at 03:53):
you were right
Mark Iantorno (Dec 04 2020 at 03:53):
you're not even using it
Mark Iantorno (Dec 04 2020 at 03:53):
just it being there causes the issue
Mark Iantorno (Dec 04 2020 at 03:54):
that's messed up
Grahame Grieve (Dec 04 2020 at 03:54):
Mark Iantorno (Dec 04 2020 at 03:54):
I'm going to comment it out and push out a quick fix
Mark Iantorno (Dec 04 2020 at 03:55):
Although I take blame for this for suggesting the library, I'm going to say that I did say it would be a piece of crap because it was maintained by eclipse
Mark Iantorno (Dec 04 2020 at 03:55):
pushing the fix right now
Mark Iantorno (Dec 04 2020 at 03:55):
release coming up
Grahame Grieve (Dec 04 2020 at 03:57):
https://stackoverflow.com/questions/33915987/git-tf-unable-to-find-required-jar - depends on MINGW
Mark Iantorno (Dec 04 2020 at 03:57):
ah, that sounds like a hack
Mark Iantorno (Dec 04 2020 at 03:58):
let me find a better library for this
Mark Iantorno (Dec 04 2020 at 03:58):
I think there must be a maven solution to this as wel
Mark Iantorno (Dec 04 2020 at 03:58):
manually defining the entry point for the ig app
Grahame Grieve (Dec 04 2020 at 03:58):
shame. I just integrated jgit - it works really well
Grahame Grieve (Dec 04 2020 at 03:58):
was about to do the PR
Mark Iantorno (Dec 04 2020 at 03:58):
this is fixable
Mark Iantorno (Dec 04 2020 at 03:59):
don't lose hope
Mark Iantorno (Dec 04 2020 at 04:18):
release is running now
Mark Iantorno (Dec 04 2020 at 04:18):
fix should be out shortly
Mark Iantorno (Dec 04 2020 at 04:18):
I'm looking at the jgit dependency now though
Grahame Grieve (Dec 04 2020 at 04:27):
I don't think I'm right about the mingw thing - I think i was looking at the wrong thing
Mark Iantorno (Dec 04 2020 at 04:28):
kk
Mark Iantorno (Dec 04 2020 at 04:40):
@Lloyd McKenzie @Elliot Silver @Grahame Grieve IGPublisher has been released with fix. It works now.
Mark Iantorno (Dec 04 2020 at 04:41):
Let me know if there are any issues.
Lloyd McKenzie (Dec 04 2020 at 04:43):
Thanks for the quick after-hours turn-around @Mark Iantorno :)
Elliot Silver (Dec 04 2020 at 04:58):
Looks good here.
Jean Duteau (Dec 04 2020 at 05:53):
Screen-Shot-2020-12-03-at-10.53.04-PM.png
Jean Duteau (Dec 04 2020 at 05:53):
(deleted)
Jean Duteau (Dec 04 2020 at 05:54):
just to poke some fun...
Mark Iantorno (Dec 04 2020 at 13:22):
@Jean Duteau I'm going to put a test in the pipeline to run the jar before allowing a merge...hopefully this won't happen again
Last updated: Apr 12 2022 at 19:14 UTC
