Stream: IG creation
Topic: Profile description markdown URLs
John Moehrke (Oct 21 2021 at 16:26):
I have added to the Profile description markdown links to pages in my IG. I did this with relative page html urls profile is used in [foo bar transaction](foobar.html) This works fine on the Artifacts page, but when viewing the description within the Profile rendering, it "assumes" that the link was to the FHIR specification. I also get a build warning coming from that profile rendering page.
John Moehrke (Oct 22 2021 at 16:55):
This is a bug that did not exist in the IG builder / template back in June. My build in June worked as expected, but today throws errors and somehow assumes the links are to FHIR R4.
John Moehrke (Oct 22 2021 at 17:05):
Here is the example using the IHE PDQm ci build https://build.fhir.org/ig/IHE/ITI.PDQm/branches/main/artifacts.html
John Moehrke (Oct 22 2021 at 17:05):
John Moehrke (Oct 22 2021 at 17:06):
that works as a relative link within the IG. -- on the artifacts page
John Moehrke (Oct 22 2021 at 17:07):
John Moehrke (Oct 22 2021 at 17:07):
that, on the profile render page, does not act as a relative URL. It presumes the link was a relative to the FHIR R4 spec.
John Moehrke (Oct 22 2021 at 17:36):
I don't think this current behavior of the IG build, to presume a relative URL should be to the FHIR version declared in the IG, is understandable but not proper. If I really wanted to link to a specific version of the FHIR core, I would use a full url. But there is no alternative but to use relative URLs for links within the IG.
Lloyd McKenzie (Oct 22 2021 at 18:06):
@Grahame Grieve
Grahame Grieve (Oct 22 2021 at 18:35):
I don't understand this. is the link wrong? or just that it's flagged as external?
John Moehrke (Oct 22 2021 at 18:49):
the first is good. the second has been changed to http://hl7.org/fhir/R4/ITI-78.html
John Moehrke (Oct 22 2021 at 18:50):
on the artifacts page it properly handled it as a relative url to pages inside the IG.
John Moehrke (Oct 22 2021 at 18:50):
but on the profile page, it got rendered as if it was refering to a resource on the FHIR R4 spec.
John Moehrke (Oct 22 2021 at 18:51):
John Moehrke (Oct 25 2021 at 12:28):
@Grahame Grieve any chance to get this fixed this or next week? IHE is needing to publish three IGs that use this markdown feature.
John Moehrke (Oct 25 2021 at 20:55):
now about this one? in a profile (might also be an instant) description with markdown, I need relative links within my IG.
now github issue https://github.com/HL7/fhir-ig-publisher/issues/328
Grahame Grieve (Oct 26 2021 at 23:01):
fixed next release
John Moehrke (Oct 29 2021 at 11:47):
@Grahame Grieve might that new release be available today? (Im working on the publication today)
Grahame Grieve (Oct 29 2021 at 11:53):
honestly... I don't like your chances. QA processes look like they'll take all day
Grahame Grieve (Oct 29 2021 at 11:54):
@Mark Iantorno I don't even know why the Ci-build failed on my PR that includes the changes John wants
Grahame Grieve (Oct 29 2021 at 11:54):
https://github.com/hapifhir/org.hl7.fhir.core/pull/634
Mark Iantorno (Oct 29 2021 at 18:15):
taking care of this with David this afternoon
Mark Iantorno (Oct 29 2021 at 19:03):
@David Otasek
Mark Iantorno (Oct 29 2021 at 19:12):
@Grahame Grieve I'm getting the same test failure locally on my machine:
Mark Iantorno (Oct 29 2021 at 19:12):
** Core:
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/mark/.m2/repository/org/slf4j/slf4j-simple/1.7.28/slf4j-simple-1.7.28.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/mark/.m2/repository/ch/qos/logback/logback-classic/1.2.3/logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.SimpleLoggerFactory]
..Detect format for code-wrong-display.xml
Start Validating (14055 to set up)
Times (ms): overall = 151, tx = 139, sd = 0, load = 176, fpe = 3
ERROR: Basic.code.coding[0]: Version 'http://snomed.info/sct/731000124108/version/20210301' of the code system 'http://snomed.info/sct' is not known (encountered paired with code = '132037003'). ValidVersions = [http://snomed.info/sct/20611000087101/version/20210331,http://snomed.info/sct/32506021000036107/version/20210630,http://snomed.info/sct/731000124108/version/20210901,http://snomed.info/sct/900000000000207008/version/20190731,http://snomed.info/sct/900000000000207008/version/20200131,http://snomed.info/sct/900000000000207008/version/20200731,http://snomed.info/sct/900000000000207008/version/20210731]; The code provided (http://snomed.info/sct#132037003) is not valid in the value set 'All codes known to the system' (from http://tx.fhir.org/r4) for 'http://snomed.info/sct#132037003'
java.lang.AssertionError: Test code-wrong-display: Expected 0 errors, but found 1.
Expected :0
Actual :1
<Click to see difference>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.hl7.fhir.validation.tests.ValidationTests.checkOutcomes(ValidationTests.java:421)
at org.hl7.fhir.validation.tests.ValidationTests.test(ValidationTests.java:256)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
Grahame Grieve (Oct 29 2021 at 19:13):
I suppose it helps if I actually push the change
Mark Iantorno (Oct 29 2021 at 19:14):
It's my old friend Pineywood-pig
Mark Iantorno (Oct 29 2021 at 19:14):
{
"name": "code-wrong-display",
"file": "code-wrong-display.xml",
"tx-dependent": true,
"java": {
"errorCount": 0,
"warningCount": 1,
"output": [
"WARNING: Basic.code.coding[0]: The display \"Pineywoods pig breed. Not.\" is not a valid display for the code {http://snomed.info/sct}132037003 - should be one of [\"Pineywoods pig\",\"Pineywoods pig breed (organism)\",\"Pineywoods pig breed\"]"
]
}
},
Mark Iantorno (Oct 29 2021 at 19:15):
Okay, let me know when this is good to go, and I'll re-run the tests
Grahame Grieve (Oct 29 2021 at 19:23):
well, it should be good to as soon as sonatype has done it's thing, right?
Mark Iantorno (Oct 29 2021 at 19:33):
Yeah, working on it now
Mark Iantorno (Oct 29 2021 at 20:57):
I merged your change in along with another for SmileCDR, and the release is running
Mark Iantorno (Oct 29 2021 at 23:43):
Releases are complete
Mark Iantorno (Oct 29 2021 at 23:43):
@John Moehrke
John Moehrke (Oct 29 2021 at 23:58):
Thanks
John Moehrke (Nov 01 2021 at 11:27):
I confirm it is working properly now.
Last updated: Apr 12 2022 at 19:14 UTC
