Stream: IG creation
Topic: PHD issues
Grahame Grieve (Nov 30 2018 at 03:06):
@Brian Reinhold ok I'm looking at PHD now...
SYSID in http://hl7.org/fhir/uv/phd/CodeSystem/ContinuaDeviceIdentifiers is not defined?
Grahame Grieve (Nov 30 2018 at 03:06):
along with several other codes?
Grahame Grieve (Nov 30 2018 at 03:07):
all the coin broken links... I do not follow why these need to be broken links. Surely, if you're referencing an example, you should have the example in the IG so implementers can see what it looks like?
Brian Reinhold (Nov 30 2018 at 10:07):
@Brian Reinhold ok I'm looking at PHD now...
SYSID in http://hl7.org/fhir/uv/phd/CodeSystem/ContinuaDeviceIdentifiers is not defined?
@Grahame Grieve It's defined ... at least it exists. This is what I have in my code system:
<concept>
<code value="SYSID"/>
<display value="IEEE 11073 System Identifier"/>
<definition value="This code indicates that the identifier is the IEEE 11073 SystemId from the equivalent of the System-Id attribute"/>
</concept>
Is that insufficient?
The examples were taken from an actual implementation which uploads measurement sequences in Bundles. Resources uploaded previously are not uploaded again (Patient, Device). Uploaded resources are also different than resources that exist on the server if they are created as there is no logical id or there is a temporary id. But in the end I was thinking like my PHMR CDA examples, where one shows an example of that template one is discussing. It just seemed overkill to have the same type of Device and Coincident time stamp examples that show nothing different. In some cases I had to 'fake' them as I have no device producing a time fault so I created a time fault Coincident time stamp example that nothing references. But the implementer can see how it is encoded.
Actually I re-made these examples as md-pages and link the reader to them in the text. In those I can put comments and remarks (no standard way to comment a JSON representation) and this is what the reader is directed to for implementation purposes as they will be different than those that sit on a server.
I added the extra examples. Increased the number of errors though. However, the types of errors are now down to 2 instead of 3.
Grahame Grieve (Nov 30 2018 at 21:00):
ah ok. so it's defined, but the IG publisher expects that you'll insert the generated narrative into the page, or otherwise ensure that there is anchors for each code in the html of the page. You are manually editing the page, and haven't inserted the anchors
Brian Reinhold (Nov 30 2018 at 21:48):
ah ok. so it's defined, but the IG publisher expects that you'll insert the generated narrative into the page, or otherwise ensure that there is anchors for each code in the html of the page. You are manually editing the page, and haven't inserted the anchors
@Grahame Grieve I hate sound sound as ignorant as I am, but what are anchors? Should I put more content in the CodeSystem <text> element?
Grahame Grieve (Nov 30 2018 at 22:05):
this is in the html, not the code system, since you are hand writing the narrative... though you should just use the generated narrative, really
Grahame Grieve (Nov 30 2018 at 22:06):
<a name="this"> </a> - that's an anchor, so that a link can point directly to that part of the page using page.html#this
Brian Reinhold (Nov 30 2018 at 22:11):
<a name="this"> </a> - that's an anchor, so that a link can point directly to that part of the page using page.html#this
@Grahame Grieve Oh yeah, I remember those. But all I am editing are the xml files (structure definitions, value sets, and code systems ... oh yea, capability statements). The Framework does everything else.
Grahame Grieve (Nov 30 2018 at 22:14):
oh you should remove the hand written narrative from the code system resource. For the terminology resources, the IG publisher will generate much better narrative than you can
Brian Reinhold (Nov 30 2018 at 22:17):
oh you should remove the hand written narrative from the code system resource. For the terminology resources, the IG publisher will generate much better narrative than you can
@Grahame Grieve If I don't put a text element in there I get an error. When I do, that's all that displays in the narrative. Its pretty thin. So I am adding more to the text element so I get something that looks like this
Code system specifying the types of device identifiers. Currently defined at this time are: SYSID: IEEE 11073 system id EUI-64 value BTMAC: Bluetooth MAC address (EUI-48) ETHMAC: Ethernet MAC address (EUI-48) USB: USB identifier PID.VID ZIGBEE: 64-bit ZigBee address
instead of just a single sentence. (Originally I just had "Code system specifying the types of device identifiers" in that text element.
WHOW! I just took the text element out and it is MUCH better. No error either. I guess that has been changed.
Grahame Grieve (Nov 30 2018 at 23:56):
not changed recently. but glad it works no
Last updated: Apr 12 2022 at 19:14 UTC
