FHIR Chat · OperationDefinition · IG creation

Stream: IG creation

Topic: OperationDefinition

Brian Postlethwaite (Jun 05 2019 at 12:11):

When generating the {% include table-operationdefinitions.xhtml %} file
It appear that in STU3 it is repeating the name in both columns.
I assume that in R4 its showing name and title in the columns.
I don't suppose that the STU3 was looking for an extension for that property? (that I could populate)

Brian Postlethwaite (Jun 05 2019 at 12:37):

Similar Question for SearchParameter resources and {% include table-searchparameters.xhtml %} in STU3 (does fall back to the description property)

Grahame Grieve (Jun 10 2019 at 21:14):

ok please check this after the next IG publisher release

Brian Postlethwaite (Jun 19 2019 at 09:35):

@Grahame Grieve Where's this code in the Publisher?
It's not doing what I expected still.

Brian Postlethwaite (Jun 19 2019 at 09:45):

Looks like the OperationDefinition name field is what is being put into the description column in the table generated template

Brian Postlethwaite (Jun 21 2019 at 02:45):

Pull request incoming for this one. - Do I need to log a tracker for this and associate that in the PR?
https://github.com/HL7/fhir-ig-publisher/pull/16
:smile:
@Grahame Grieve , I assume you're the one that processes these...

Grahame Grieve (Jun 21 2019 at 04:39):

PR is fine

Brian Postlethwaite (Jun 21 2019 at 05:39):

Did you like the spelling error correction? @Lloyd McKenzie
https://github.com/HL7/fhir-ig-publisher/pull/16/commits/afec4391bbb114ee357c7f6d8a5fef9b2aa4d6d3

Brian Postlethwaite (Jun 25 2019 at 12:36):

@Grahame Grieve , since I see you're making commits on the IG publisher, I guess you've dealt with this one.
I only minutes ago created another pull request following on from this one...

Grahame Grieve (Jun 25 2019 at 12:37):

which also included this one... so please abandon it and submit a new PR with just those other changes

Brian Postlethwaite (Jun 25 2019 at 12:39):

Will do, I'm checking over those last commits you did

Grahame Grieve (Jun 25 2019 at 12:40):

k thx

Brian Postlethwaite (Jun 25 2019 at 12:45):

I'll test over it, but I don't see how this works now :thinking:
My pull request didn't cover the load/scan issue, just the other smaller issues.

Brian Postlethwaite (Jun 25 2019 at 12:46):

I see you did resolve the load/scan issue, not the others I requested in the PR.

Grahame Grieve (Jun 25 2019 at 12:47):

what others?

Brian Postlethwaite (Jun 25 2019 at 12:47):

the comments in the PR. It wasn't for the load/scan bug.

Grahame Grieve (Jun 25 2019 at 12:48):

I fixed the stuff in the other PR - the description thing, and the typos

Brian Postlethwaite (Jun 25 2019 at 12:48):

Sorry, you must have pushed just after I'd done the last fetch.

Grahame Grieve (Jun 25 2019 at 12:49):

what did I miss?

Brian Postlethwaite (Jun 25 2019 at 12:49):

Checking now.

Brian Postlethwaite (Jun 25 2019 at 12:53):

Nah, you got them.
I'll get another PR done with the new changes on it. Thanks

Grahame Grieve (Jun 25 2019 at 12:53):

ok great

Brian Postlethwaite (Jun 25 2019 at 13:05):

New PR created with just the new changes, and re-checked that it's doing what I expected. Will check on my other IG that has the validation issues that that part is sorted.

Grahame Grieve (Jun 25 2019 at 13:15):

ok accepted that. It'll be released next time I do a release. Which won't be toight

Brian Postlethwaite (Jun 25 2019 at 13:16):

No problems, thanks heaps.
I'm might be doing some more cleanups like this around examples, so might make sense to batch them in.

Grahame Grieve (Jun 25 2019 at 13:17):

ok

Brian Postlethwaite (Jul 01 2019 at 06:58):

Another issue with the OperationDefinition is that the narrative generator doesn't treat the description as a markdown type (as was just a string previously) where do I log that issue to be resolved?
(Effect is that if you want pretty narrative for your OperationDefinition resource you have to create that yourself and put into the resource in the IG.
(can't let the IG Builder just do it)

Lloyd McKenzie (Jul 01 2019 at 14:15):

Submit a change request for the IG Publisher

Grahame Grieve (Jul 03 2019 at 23:00):

I see it processing it as markdown:

public boolean generate(ResourceContext rcontext, OperationDefinition opd) throws EOperationOutcome, FHIRException, IOException {
    XhtmlNode x = new XhtmlNode(NodeType.Element, "div");
    x.h2().addText(opd.getName());
    x.para().addText(Utilities.capitalize(opd.getKind().toString())+": "+opd.getName());
    x.para().tx("The official URL for this operation definition is: ");
    x.pre().tx(opd.getUrl());
    addMarkdown(x, opd.getDescription());

Brian Postlethwaite (Jul 04 2019 at 02:22):

Thanks, I'll look into what's going on then and debug through it.
Cant get newlines coming through..

Last updated: Apr 12 2022 at 19:14 UTC