Stream: IG creation
Topic: New Publisher errors
Sarah Gaunt (Dec 17 2021 at 03:35):
So I literally changed one letter in a slice definition in a StructureDefintion and now have a bunch of errors in the IG. Pretty sure that the errors aren't from my spelling error change. Two days ago there were 0 errors, now there are 14:
Before I go down a deep rabbit-hole - are the following errors really errors with the IG or is there a possibility they are artifacts of the new publisher:
Grahame Grieve (Dec 17 2021 at 03:36):
certainly looks like I did something wrong
Grahame Grieve (Dec 17 2021 at 03:36):
how do I reproduce?
Sarah Gaunt (Dec 17 2021 at 03:37):
It's eCR: https://github.com/HL7/case-reporting/tree/master
Sarah Gaunt (Dec 17 2021 at 03:38):
http://build.fhir.org/ig/HL7/case-reporting/branches/master/qa.html
Sarah Gaunt (Dec 22 2021 at 20:34):
@Grahame Grieve any idea about these errors. @Adam Stevenson has had a look and doesn't think they are issues with the IG.
Grahame Grieve (Dec 23 2021 at 02:01):
should be gone with the latest version of the IG publisher (from a couple of hours ago)
Sarah Gaunt (Dec 23 2021 at 02:46):
Genius! Thanks - just checked and errors gone... :tada:
Larry Decelles (Feb 10 2022 at 16:40):
Hello, @Grahame Grieve @Lloyd McKenzie, after a build we noticed these links (below in bold) are broken. It appears the *.html files were not created.
These links can be found on http://build.fhir.org/ig/HL7/davinci-dtr/StructureDefinition-dtr-sdc-questionnaire-definitions.html#l1521
We are using the latest publisher. Is this a publisher issue?
** http://build.fhir.org/ig/HL7/davinci-dtr/OperationDefinition-Questionnaire-assemble.html
http://build.fhir.org/ig/HL7/davinci-dtr/StructureDefinition-sdc-questionnaire-subQuestionnaire.html
http://build.fhir.org/ig/HL7/davinci-dtr/extraction.html**
Chris Moesel (Feb 10 2022 at 17:05):
To provide a little more context, I think that the DTR profile is inheriting these element definitions from the SDC profile it is based on (and in one case the SDC extension it uses). The inherited definitions have relative links to pages that only exist in the SDC IG. Ideally, these links would be converted to absolute links to the SDC pages during snapshot generation.
Grahame Grieve (Feb 10 2022 at 19:38):
indeed that's supposed to happen
Grahame Grieve (Feb 11 2022 at 03:49):
@Lloyd McKenzie there's two problems here. The first is that the path for the item link is fictional. I don't know why that is, but it's a code issue. The other is that the IG prublisher expects that there'll be a definitions page for Questionnaires, which it's trying to link to. But there isn't
Lloyd McKenzie (Feb 11 2022 at 03:53):
Why is it expecting a definitions page for Questionnaires? It wasn't for SDC - at least not several days ago...
When you say it's a code issue, do you mean publisher or template?
Grahame Grieve (Feb 11 2022 at 03:55):
actually, I'm wrong. This is just a straight state error in the IG publisher. But the rendering for the QR is the resource narrative. This is nearly the same, but not quite, as the rendering for the questionnaire response, which links to the questionnaire correctly.
Grahame Grieve (Feb 11 2022 at 03:55):
so the template is wrong here - there's a fragment prepared for the QR that should be used in preference to the resource narrative
Grahame Grieve (Feb 11 2022 at 03:58):
there was another error in the code to do with definitions - mislead me
Lloyd McKenzie (Feb 11 2022 at 04:18):
The narrative for the Questionnaire should be displayed - it might not always be your auto-generated narrative. Enhancing the template to support the new Questionnaire rendering capabilities is on my list, but I don't want to mess with it until the initial set of template changes (and SDC and ballots) are out the door.
Grahame Grieve (Feb 11 2022 at 04:24):
hmm it might be, that's true. but the generic generated narrative can never be contextualised to the IG like a IG generated narrative can be
Lloyd McKenzie (Feb 11 2022 at 17:15):
I'm not really following what you're saying. My point is, that even when we update the template, the template will include a tab that includes the narrative. And if the narrative happens to be the generic generated narrative, that'll need to work and not cause broken links...
Grahame Grieve (Feb 11 2022 at 19:14):
right. but it also won't be as well linked into the IG because the generated narrative is general purpose - suitable for the many people who load the examples into their servers. In the case of QuestionnaireResponse, I can link all the questionnaire items from the response to the questionnaire. But the link is IG specific - where the IG put the questionnaire in the HTML. I can generate it with or without the links, and do.
Grahame Grieve (Feb 11 2022 at 19:15):
but I guess the other resources include links like that and no one has ever complained
Last updated: Apr 12 2022 at 19:14 UTC
