FHIR Chat · Missing ValueSet in Snapshot · IG creation

Stream: IG creation

Topic: Missing ValueSet in Snapshot


view this post on Zulip Chris Moesel (Aug 18 2018 at 00:28):

We have a profile on US Core's Condition and it binds the US Core Condition Category Value Set to category, but in the published doc, the name is missing:

pasted image

Here's the source:

"binding": {
   "strength": "preferred",
  "valueSetReference": {
    "reference": "http://hl7.org/fhir/us/core/ValueSet/us-core-condition-category"
  }
},

https://github.com/HL7/us-breastcancer/blob/master/resources/structuredefinition-oncology-BreastCancerPresenceStatement.json#L707-L711

view this post on Zulip Grahame Grieve (Aug 18 2018 at 00:49):

hmm. I think were getting to the point of 'please create a task for me to fix this'

view this post on Zulip Chris Moesel (Aug 18 2018 at 00:52):

OK. I'll log a task. We don't consider it a show-stopper anyway.

view this post on Zulip Grahame Grieve (Aug 18 2018 at 00:57):

have you sorted out about ballot?

view this post on Zulip Chris Moesel (Aug 18 2018 at 01:09):

I think so, although I see that the ballot desktop hasn't been updated yet. But yes, the ballot is expected to go on.

view this post on Zulip Brett Esler (Aug 18 2018 at 01:14):

Is your ValueSet.title populated? I found this helps... I assume in the full description of the element the binding is there

view this post on Zulip Chris Moesel (Aug 18 2018 at 01:18):

@Brett Esler -- you may be on to something. Unfortunately, this is not our Value Set -- it is from US Core. But looking at their definition, I see that title is definitely not there: http://hl7.org/fhir/us/core/ValueSet-us-core-condition-category.json.html

view this post on Zulip Brett Esler (Aug 18 2018 at 01:24):

I think something changed recently IG build - title would seem to make more sense as it is the 'human-friendly' text rather than the name 'computer-friendly' text; but would be good if fell back to ValueSet.name if no title...

view this post on Zulip Grahame Grieve (Aug 18 2018 at 01:26):

ok I just committed that

view this post on Zulip Chris Moesel (Aug 18 2018 at 01:27):

And, of course, I _just_ filed the ticket: https://gforge.hl7.org/gf/project/fhir/tracker/?action=TrackerItemEdit&tracker_item_id=17691

view this post on Zulip Brett Esler (Aug 18 2018 at 01:29):

that is quick service on the ticket ;)

view this post on Zulip Chris Moesel (Aug 18 2018 at 01:32):

According to the #committers stream, the ticket and fix were within one minute of each other.

view this post on Zulip Grahame Grieve (Aug 18 2018 at 01:37):

hah, well, I didn't not expect such a gift to identify the exact cause, and I'm just guessing at the solution, but it seemed worth a try

view this post on Zulip Brett Esler (Aug 18 2018 at 01:46):

notice the Detailed Descriptions reference the ValueSet.name rather than title (snapshot/differential) - guess this should be consistent? e.g. http://build.fhir.org/ig/HL7/us-breastcancer/StructureDefinition-oncology-BreastTumor-definitions.html#Condition:oncology-BreastTumor.category

view this post on Zulip Chris Moesel (Aug 18 2018 at 02:46):

Grahame's fix worked! Yay! Thanks @Brett Esler and @Grahame Grieve!


Last updated: Apr 12 2022 at 19:14 UTC