Stream: IG creation
Topic: JIRA Spec name artifacts collission
Joshua Kelly (Nov 03 2021 at 17:47):
When we generate the JIRA spec with publisher, we get a file that does not successfully build in HL7/JIRA-Spec-Artifacts because the validation step fails because of 3 duplicate keys in the generated XML.
Duplicate unique value [C4DIC Extended Contact Type] declared for identity constraint "artifact-name-unique" of element "specification".
Duplicate unique value [C4DIC Extended Copay Type] declared for identity constraint "artifact-name-unique" of element "specification".
Duplicate unique value [C4DIC Extended Coverage Class] declared for identity constraint "artifact-name-unique" of element "specification".
Here is a direct link to this error in the build: https://github.com/HL7/JIRA-Spec-Artifacts/runs/4015537366?check_suite_focus=true
We fixed this manually by changing the outputted XML (merged in this PR https://github.com/HL7/JIRA-Spec-Artifacts/pull/317) but obviously it is preferable to get this to work so there is no warning.
Our IG: https://github.com/HL7/carin-digital-insurance-card
This is the unaltered XML that is currently generated, which makes the above error (FHIR-us-carin-dic.xml): https://github.com/jdjkelly/JIRA-Spec-Artifacts/blob/10867518fa30d10851c1fa140ac17c58da1f0385/xml/FHIR-us-carin-dic.xml
This is the altered XML we submitted (altering the names of the 3 codesets and valuesets have unique names in this case): https://github.com/jdjkelly/JIRA-Spec-Artifacts/blob/669abc283c26534d3ad25397a729984c35106f15/xml/FHIR-us-carin-dic.xml
Here is the FSH for the profiles that seem to be generating the name collissions: https://github.com/HL7/carin-digital-insurance-card/blob/master/input/fsh/CoverageProfile.fsh
Thanks for any insight anyone may have! cc @Cille Kissel Watkins @Corey Spears
Joshua Kelly (Nov 03 2021 at 17:48):
You can see a direct diff of the changes we submitted manually to the XML here: https://github.com/HL7/JIRA-Spec-Artifacts/pull/317/commits/669abc283c26534d3ad25397a729984c35106f15
Jean Duteau (Nov 03 2021 at 17:50):
your value sets and code systems have the same name. You need to change the names so that they are unique - add "value set" or "VS" or something to distinguish the code system from the value set
Jean Duteau (Nov 03 2021 at 17:54):
it's not the profiles but the CodeSystems.fsh and the ValueSets.fsh that have artifacts with the same name.
Corey Spears (Nov 03 2021 at 20:29):
Jean is correct. This is something that the CARIN BlueButton IG decided to do as well. I am not sure why as it was before my engagement, but it does require manual modification of the generated jira file every time. I would recommend changing the names (Title) in the source fsh file instead.
Joshua Kelly (Nov 03 2021 at 20:43):
Thanks @Jean Duteau and @Corey Spears , you've unblocked us.
I've made an appropriate change and we are discussing as a group now (https://github.com/HL7/carin-digital-insurance-card/pull/22).
Thanks again!
Last updated: Apr 12 2022 at 19:14 UTC
