FHIR Chat · Incorrect error re fhir-spec.zip · IG creation

Stream: IG creation

Topic: Incorrect error re fhir-spec.zip


view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 05:28):

I get this message in my QA: The link 'http://hl7.org/fhir/R4/fhir-spec.zip' for "FHIR R4 core" cannot be resolved
However, that link absolutely resolves - and it's the same link found on the downloads page in the R4 spec...

view this post on Zulip Grahame Grieve (Jul 28 2020 at 05:29):

can I reproduce?

view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 05:31):

I'll be pushing ehrx in the next 30 minutes or so. Will tell you when.

view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 05:31):

Similar issue here: The link 'http://hl7.org/fhir/us/core/STU3' for "US Core 3.1 (FHIR R4)" cannot be resolved

view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 05:33):

And this: The link 'here' for "http://hl7.org/fhir/R4/downloads.html#refimpl" cannot be resolved

view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 05:40):

Ignore the last - that's just my stupidity :)

view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 05:53):

Ok, IG showing the first two unbroken broken links is up: https://build.fhir.org/ig/HL7/davinci-ehrx/qa.html#internal

view this post on Zulip Grahame Grieve (Jul 28 2020 at 07:59):

the first link - fixed next release. The second link should be http://hl7.org/fhir/us/core/STU3.1 not http://hl7.org/fhir/us/core/STU3

view this post on Zulip Lloyd McKenzie (Jul 28 2020 at 13:50):

For the second one, my IG declares this as the dependency:
<dependsOn id="uscore">
<uri value="http://hl7.org/fhir/us/core/ImplementationGuide/hl7.fhir.us.core"/>
<packageId value="hl7.fhir.us.core"/>
<version value="3.1.0"/>
</dependsOn>

And this is what shows up in site.data.fhir:
"uscore": "http://hl7.org/fhir/us/core"

Should it not be returning a version-specific URL?

view this post on Zulip Grahame Grieve (Jul 28 2020 at 19:55):

you have the wrong version specific URL

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 00:42):

So the URI needs to be version-specific?

view this post on Zulip Grahame Grieve (Jul 29 2020 at 00:42):

you are using a version specific URl, just the wrong one

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 00:43):

In the IG, I don't see any version reference except in <version/> I think that value is correct?

view this post on Zulip Grahame Grieve (Jul 29 2020 at 00:44):

it's in the narrative for fhir.html

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 00:46):

I'm not following. I've got a dependency declared in my IG. I changed what's in fhir.html. My issue now is what's showing up in site.data.fhir.uscore - which is what I changed fhir.md to reference.

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 00:46):

I think it should be a version-specific URL, instead of the generic URL.

view this post on Zulip Grahame Grieve (Jul 29 2020 at 00:47):

I don't have a clue what you are talking about. The problem is this fragment in the markdown:

view this post on Zulip Grahame Grieve (Jul 29 2020 at 00:47):

builds on the [US Core 3.1 (FHIR R4)](http://hl7.org/fhir/us/core/STU3) implementation guide

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 02:50):

That was fixed yesterday in my local build. I've pushed it up so you can see the problem

view this post on Zulip Grahame Grieve (Jul 29 2020 at 02:59):

misspelling? [R4]({{site.dta.fhir.path}}index.html)

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 03:00):

That's not going to fix the problem, but I'll push the fix

view this post on Zulip Grahame Grieve (Jul 29 2020 at 03:01):

so now I'm not sure what the problem is. there's no broken links anymore

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 03:01):

Pushed

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 03:01):

It's not that the link is broken, it's that it's not a version-specific link. And it should be.

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 03:02):

If US Core pushes out a 3.2 that moves a bunch of stuff around (or eventually an 4.0 that rejigs things further), all of my links would break - because they're not getting the version-specific URL.

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 03:02):

The path that's spit out for dependent igs in _data/fhir.json should be version-specific.

view this post on Zulip Grahame Grieve (Jul 29 2020 at 03:06):

well, I'm not going to change the existing value, but the next release will add to the fhir.json file so that you can do

[US Core 3.1 (FHIR R4)]({{site.data.fhir.ver.uscore}})

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 03:18):

Why would it be inappropriate to change the existing value?

view this post on Zulip Lloyd McKenzie (Jul 29 2020 at 03:18):

In what situations should IGs point to versionless?

view this post on Zulip Grahame Grieve (Jul 29 2020 at 04:13):

because I don't want to test several hundred IGs to see what would be broken and there are circumstances where some users want to point to latest

view this post on Zulip Jean Duteau (Aug 18 2020 at 03:32):

I'm going to piggy back on this thread because I'm having the same problem with a link that is reported as being broken when it isn't.

The link 'http://hl7.org/fhir/us/core/STU3.1/full-ig.zip' for "US-Core" cannot be resolved

I've tried both ({{site.data.fhir.ver.hl7_fhir_us_core}}/full-ig.zip). and ({{site.data.fhir.hl7_fhir_us_core}}/full-ig.zip) and both give me a broken link.

view this post on Zulip Grahame Grieve (Aug 18 2020 at 03:34):

fixed next release. I never expected someone would provide a link to download a different IG

view this post on Zulip Grahame Grieve (Aug 18 2020 at 03:35):

because they won't cross-link to each other once downloaded


Last updated: Apr 12 2022 at 19:14 UTC