Stream: IG creation
Topic: IG publisher version of date
Jean Duteau (Jul 07 2020 at 16:40):
I'm getting a spurious error in my qa.html:
IG Publisher Version: v1.1.2, which is out of date. The current version is v1.0.101-SNAPSHOT Download Latest
Lloyd McKenzie (Jul 07 2020 at 16:51):
Locally or on the CI- build?
Jean Duteau (Jul 07 2020 at 16:51):
locally
Lloyd McKenzie (Jul 07 2020 at 16:52):
And you've grabbed the most recent publisher?
Jean Duteau (Jul 07 2020 at 16:52):
yes. that's why the error is spurious. I have 1.1.2 but the check complains because it thinks an earlier version (1.0.101-SNAPSHOT) is current.
Lloyd McKenzie (Jul 07 2020 at 16:53):
@Jose Costa Teixeira Did we miss updating the code that checks for current in the migration to the new place for storing the authoritative version?
Jose Costa Teixeira (Jul 07 2020 at 16:56):
I don't know where is the code that checks for current.
We changed the link,
https://github.com/HL7/fhir-ig-publisher/commit/f584a4c1cb2db4336fb90770fcce8b60beac124f#diff-2309efc34c4c413997bfeed23baf82efR808
Jose Costa Teixeira (Jul 07 2020 at 16:57):
let me quickly debug to see if I can find where is that defined
Jose Costa Teixeira (Jul 07 2020 at 17:04):
https://fhir.github.io/latest-ig-publisher/tools.json
Jose Costa Teixeira (Jul 07 2020 at 17:04):
Seems this needs to be updated
Grahame Grieve (Jul 07 2020 at 22:07):
we have abandoned that file. @Mark Iantorno is fixing this
Mark Iantorno (Jul 08 2020 at 17:58):
Alright, so I have a new solution for this. At first I was tempted to replicate the same functionality we currently have, meaning we would store the necessary release version variables in a hosted file somewhere that people could view easily. But, after looking into that approach, I felt it went against the new release process we are adopting, and opted to go with using the exposed GitHub api to poll the current latest version name from the published releases.
Mark Iantorno (Jul 08 2020 at 17:59):
if you want to test this locally on your machine you can view the entire json object by running the following curl command: curl "https://api.github.com/repos/HL7/fhir-ig-publisher/releases/latest"
Mark Iantorno (Jul 08 2020 at 18:00):
if you want to view just the release version, you can search for either the "tag_name" or "name" of the published release with the following curl command: curl "https://api.github.com/repos/HL7/fhir-ig-publisher/releases/latest" | grep -Po '"tag_name": "\K.*?(?=")'
Mark Iantorno (Jul 08 2020 at 18:01):
If you do not trust curl, or the command line, or do not like typing, you can simply view the latest release version on the GitHub releases page here: https://github.com/HL7/fhir-ig-publisher/releases
Mark Iantorno (Jul 08 2020 at 18:01):
at the time of typing this, the version should be 1.1.2
Mark Iantorno (Jul 08 2020 at 18:01):
Mark Iantorno (Jul 08 2020 at 18:02):
I'm updating the code in both the validator and publisher to reflect this.
Mark Iantorno (Jul 08 2020 at 18:04):
Changes to the IG-Publisher library can be viewed here: https://github.com/HL7/fhir-ig-publisher/pull/127
Mark Iantorno (Jul 08 2020 at 18:21):
I jsut verified the publisher changes against the latest US core, and there are no longer any instances of SEARCHPARAMETER_EXP_WRONG
in the results, and the publisher runs as intended.
Mark Iantorno (Jul 08 2020 at 18:22):
Once this pull request is merged, the error should be resolved.
Mark Iantorno (Jul 08 2020 at 18:34):
...and just to echo what Grahame said above, the file https://fhir.github.io/latest-ig-publisher/tools.json, will no longer be updated with the latest release information in the future. Please refer to the GitHub pages for the individual projects to see the release versions and notes. If you need assistance with this, or are having issues, please message me and I'll be happy to assist.
Mark Iantorno (Jul 08 2020 at 18:35):
There's been a lot of work put into the documentation and release process to make this more transparent for users and contributors, and any feedback you have would be appreciated.
Jose Costa Teixeira (Jul 08 2020 at 18:36):
I like this solution - reusing the github releases.
Jose Costa Teixeira (Jul 26 2020 at 14:48):
@Mark Iantorno
https://github.com/HL7/fhir-ig-publisher/blob/23949131ee19f52c6616894faf303fe79e06fe00/org.hl7.fhir.publisher.core/src/main/java/org/hl7/fhir/igtools/publisher/Publisher.java#L861
this prefixes the version string with a v
So I think this compares "v1.1.3" with "1.1.3"
https://github.com/HL7/fhir-ig-publisher/blob/d8567472d631de91828c47913f7c1a76b709f5ee/org.hl7.fhir.publisher.core/src/main/java/org/hl7/fhir/igtools/renderers/ValidationPresenter.java#L799
Jose Costa Teixeira (Jul 26 2020 at 14:48):
so it will always return false
Jose Costa Teixeira (Jul 26 2020 at 14:49):
i don't know if the solution is remove the v on the left or add the v on the right othwewise I'd submit a PR
Jose Costa Teixeira (Jul 26 2020 at 14:49):
David Pyke (Jul 26 2020 at 14:51):
Unless, for some reason, the v on the left is significant, the v in Version: v1.1.3 is redundant.
Jose Costa Teixeira (Jul 26 2020 at 15:09):
both files where this seems to come from do not include a v prefix, this is why my first guess is this v
Jose Costa Teixeira (Jul 26 2020 at 15:27):
given my ability to read java is trumpery, I leave it to others.
Jose Costa Teixeira (Jul 26 2020 at 15:29):
(my new word of the day: https://www.merriam-webster.com/thesaurus/trumpery)
Grahame Grieve (Jul 27 2020 at 04:48):
fixed.
Grahame Grieve (Jul 27 2020 at 04:48):
the code, I mean. I can't fix any trumpery you have
Mark Iantorno (Jul 27 2020 at 12:35):
Ah, yeah this is due to the labels in GitHub publishing without the 'v' prefix anymore. Thanks for finding that
Last updated: Apr 12 2022 at 19:14 UTC