Stream: IG creation
Topic: IG Publisher: Bug if List Instance contains encounter
Patrick Werner (Sep 10 2021 at 11:51):
If an Instance of List contains a reference to an Encounter in list.encounter - IG publisher fails:
Exception in thread "main" java.lang.Error: Wrong node type
at org.hl7.fhir.utilities.xhtml.XhtmlNode.addText(XhtmlNode.java:270)
at org.hl7.fhir.utilities.xhtml.XhtmlNode.tx(XhtmlNode.java:638)
at org.hl7.fhir.r5.renderers.ListRenderer.shortForRef(ListRenderer.java:222)
at org.hl7.fhir.r5.renderers.ListRenderer.render(ListRenderer.java:62)
at org.hl7.fhir.r5.renderers.ResourceRenderer.render(ResourceRenderer.java:84)
at org.hl7.fhir.igtools.publisher.Publisher.generateNarratives(Publisher.java:1180)
at org.hl7.fhir.igtools.publisher.Publisher.loadConformance(Publisher.java:3921)
at org.hl7.fhir.igtools.publisher.Publisher.createIg(Publisher.java:897)
at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:752)
at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:8664)
Patrick Werner (Sep 10 2021 at 11:51):
project to reproduce: https://github.com/patrick-werner/listEncounterFHIRbug
Patrick Werner (Sep 10 2021 at 11:59):
Filed an issue: https://github.com/HL7/fhir-ig-publisher/issues/315
John Moehrke (Feb 01 2022 at 15:32):
I have a slightly, but related, different problem. It is very specific to the List resource. Anytime I use .contained with List, I get IG build warnings. These warnings complain about not finding the .html pages for the contained resources. When a contained resource does not get their own page. The rendering of the List instance looks different than rendering of Observation.
See my example IG -- http://build.fhir.org/ig/JohnMoehrke/testList/branches/main/index.html
John Moehrke (Feb 01 2022 at 15:33):
github repo -- https://github.com/JohnMoehrke/testList
John Moehrke (Feb 01 2022 at 15:33):
is this a new IG builder issue? Is this a IG templating issue? @Grahame Grieve
Lloyd McKenzie (Feb 01 2022 at 15:43):
Actually, it happens more commonly with contained resources. There's a fix to both templates and publisher that I'm finishing testing now, so should be available 'soon'
John Moehrke (Feb 01 2022 at 15:47):
good to know. I don't recall this happening a few months ago, but during the great CI-Build purge of 2022, I was forced to rebuild an IG and have been trying to track this down for a day.
Jean Duteau (Feb 01 2022 at 16:06):
John Moehrke said:
but during the great CI-Build purge of 2022
me in the future:
I remember way back when, and I don't mean to scare you young rascals, but we had chaos for days during the great CI-Build purge. He whose name shall not be mentioned but who some say was the great Josh Mandel reigned hellfire from on high as He purged builds left, right, and center. We did not realize it at the time but He was testing us and our commitment. That day will always be remembered.
John Moehrke (Feb 01 2022 at 16:10):
that deserves to be memorialized
John Moehrke (Feb 02 2022 at 21:26):
Lloyd McKenzie said:
Actually, it happens more commonly with contained resources. There's a fix to both templates and publisher that I'm finishing testing now, so should be available 'soon'
@Lloyd McKenzie is there as jira or github/issue tracking this fix?
Lloyd McKenzie (Feb 02 2022 at 23:38):
https://github.com/HL7/fhir-ig-publisher/pull/386/
Rob Eastwood (Feb 04 2022 at 05:43):
Hi folks; follow-up question about rendering List instances:
John Moehrke said:
...The rendering of the List instance looks different than rendering of Observation.
I think am seeing the same thing with List instances - extensions not displayed, different elements running onto the same line, element names not enboldened. Taking your inspiration John, I created a stripped down IG to demonstrate this:
- a R4 List example copied and commented out the hand-crafted narrative - see here
- a simple List example with a core spec List extension - see here
Questions
- @Lloyd McKenzie - does your linked PR #386 address this?
- or is this a new / elsewhere documented issue? (I have searched and found only this thread)
Lloyd McKenzie (Feb 04 2022 at 06:02):
Nope. Mine is focused on contained resources and some rendering enhancements
Rob Eastwood (Feb 04 2022 at 06:04):
Thanks @Lloyd McKenzie
Rob Eastwood (Feb 06 2022 at 23:06):
Re List example rendering: created new thread rather than hijack this one:
https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Rendering.20List.20examples.20-.20seems.20consistent
Last updated: Apr 12 2022 at 19:14 UTC
