Stream: IG creation
Topic: HL7 / JIRA-Spec-Artifacts PR
Mohammad Jafari (Apr 02 2020 at 16:37):
Is there a protocol for PRs against HL7 / JIRA-Spec-Artifacts? I am trying to resolve the following IG build warning
The jira specification file appears to be out of date with the versions, artifacts and pages currently defined in the IG. A proposed revised file to be reviewed and, if appropriate, submitted as a pull request against the XML folder in https://github.com/HL7/JIRA-Spec-Artifacts.
and my first attempt is this PR:
https://github.com/HL7/JIRA-Spec-Artifacts/pull/17
I appreciate some help with this @Lloyd McKenzie
Lloyd McKenzie (Apr 02 2020 at 17:00):
That was correct, but you'll also have to reference the new IG in the SPECS-FHIR.xml file. If you want to update the pull request, and it passes, I can merge it. (Without a reference in SPECS-FHIR, your new specification file won't actually be checked.)
Mohammad Jafari (Apr 02 2020 at 17:32):
@Lloyd McKenzie I'm getting a vague error after adding the entry. Note that the schema of the file SPECS-FHIR.xml does not allow numbers in the key attribute for specifications so the value of this attribute as well as the file name which (apparently) must match it, been set to ds-for-p even though the name of the IG is ds4p.
/home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/build.xml:39: Fatal error during transformation using /home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/tools/buildSpecJSON.xslt: Processing terminated by xsl:message at line 95 in buildSpecJSON.xslt; SystemID: file:/home/runner/work/JIRA-Spec-Artifacts/JIRA-Spec-Artifacts/tools/buildSpecJSON.xslt; Line#: 95; Column#: -1
Lloyd McKenzie (Apr 02 2020 at 17:41):
Right - so you have to look up higher in the log to see what the specific message is
Mohammad Jafari (Apr 02 2020 at 17:50):
(deleted)
Mohammad Jafari (Apr 02 2020 at 18:06):
Thanks. This seems to be ready now.
Mohammad Jafari (Apr 02 2020 at 22:00):
@Lloyd McKenzie after you merged the PR against JIRA-Specs-Artifacts, I'm still getting this warning in the qa report:
warning The jira specification file appears to be out of date with the versions, artifacts and pages currently defined in the IG. A proposed revised file to be reviewed and, if appropriate, submitted as a pull request against the XML folder in https://github.com/HL7/JIRA-Spec-Artifacts.
Lloyd McKenzie (Apr 02 2020 at 22:09):
Is the XML file identical (including white-space) to the generated sample file now produced? It does a strict file compare there because I wasn't sure how to make it smarter.
Mohammad Jafari (Apr 02 2020 at 22:20):
@Lloyd McKenzie Can you please clarify which two XML files I should compare? I'm not sure I understand which other XML file should match the one in the JIRA repo.
Lloyd McKenzie (Apr 03 2020 at 03:04):
The FHIR-[spec id].xml file. The build process should generate a sample one. Now that you've committed your initial version, check that the generated one still reflects what you want, then commit that one exactly
Mohammad Jafari (Apr 03 2020 at 14:00):
@Lloyd McKenzie the auto-generated file leaves the default workgroup empty. I hope that's ok if I have to commit this file verbatim then I can't fill that in.
Mohammad Jafari (Apr 03 2020 at 14:01):
I'm also confused about why I had to commit the initial version if the CI expects this auto-generated file verbatim.
Mohammad Jafari (Apr 03 2020 at 14:20):
Aaand I can't update this now:
[xslt] Version with code 0.1 in specification FHIR-security-label-ds-for-p has been removed or changed. Versions should never change. Keys should also not be removed. Versions can only be removed if no JIRA tracker references that version. If this is the case and the version should really be removed, please coordinate with an administrator.
Lloyd McKenzie (Apr 03 2020 at 16:36):
The generation of the file should be blowing up because the contact url in your IG is http://hl7.org/Special/committees/security instead of http://hl7.org/Special/committees/secure. I have no idea why it's not.
Lloyd McKenzie (Apr 03 2020 at 16:37):
You need to commit the initial file because the default generated keys and choices around deprecation may not be appropriate. Once you've specified those, the generation process takes those as overrides for its generated defaults
Lloyd McKenzie (Apr 03 2020 at 16:39):
Don't remove 0.1 - deprecate it instead
Last updated: Apr 12 2022 at 19:14 UTC
