Stream: IG creation
Topic: Forthcoming fix for IG publisher that impacts all authors
Grahame Grieve (Aug 23 2018 at 23:10):
@all
There's what I think of as a bug in the IG publisher, which I'm about to fix. The fix may impact IG source.
The bug is that the content in path.specification in ig.json gets used in several places, all of which I append a "/" to if it is no present. Except one. So it doesn't matter whether you specify "http://build.fhir.org" or "http://build.fhir.org/". Except for what goes in {{site.data.fhir.path}} in Jekyll - that doesn't have a / appended. So this line:
<a href="{{site.data.fhir.path}}profiling.html#representation">Description of Profiles, Differentials, and Snapshots</a>
Whether this generates correctly or not depends on the value in the ig.json. Here's what I'm going to do: I'm going to update the code so that {{site.data.fhir.path}} always finishes with a /. I've searched all the igs that are in the FHIR space for {{site.data.fhir.path}}/ and I don't see any. I will correct all the published guides on hl7.org for this retrospectively as much as I can.
But if your IG is outside the HL7 space, and you have {{site.data.fhir.path}}/ in the source, you'll have to fix it yourself
Richard Townley-O'Neill (Aug 23 2018 at 23:31):
paths.specification
Grahame Grieve (Aug 23 2018 at 23:49):
oops, yes
Sarah Gaunt (Aug 24 2018 at 00:34):
So just tested this and the link works now - but there is a double / in the path '''http://hl7.org/fhir/STU3//profiling.html#representation'''
I guess that's ok?
Grahame Grieve (Aug 24 2018 at 00:41):
not really since (a) I haven't fixed anything and (b) I can't find any links like that
Grahame Grieve (Aug 24 2018 at 00:41):
not in the hl7 source anyway. where do you see it?
Sarah Gaunt (Aug 24 2018 at 00:42):
Oh - that was my local build - maybe that's why I never found the issue with the publisher - if the links were working locally....
Sarah Gaunt (Aug 24 2018 at 00:42):
Just assumed you had fixed and that's why the links started working!
Grahame Grieve (Aug 24 2018 at 01:05):
I don't get it in my local build. that suggests that there's a problem somewhere
Sarah Gaunt (Aug 24 2018 at 01:20):
Could be on my end - I've probably broken something over here.
Sarah Gaunt (Aug 24 2018 at 01:31):
Looks all good on the ballot site - thanks @Grahame Grieve !!
Eric Haas (Aug 24 2018 at 02:33):
seriously none of my igs have {{site.data.fhir.path}}/ , I thought I did that a lot?
Sarah Gaunt (Aug 24 2018 at 02:34):
Well, you did in eCR - it was yours originally! :)
Grahame Grieve (Aug 24 2018 at 02:53):
@Eric Haas you have {{site.data.fhir.path}} a lot, but not {{site.data.fhir.path}}/ but actually there are some. I searched wrong.
Last updated: Apr 12 2022 at 19:14 UTC
