Stream: IG creation
Topic: Extra external link icon in built IG
Max Masnick (Aug 18 2021 at 00:30):
I just noticed our ballot version has an extra external link indicator icon in the yellow box: image.png
Max Masnick (Aug 18 2021 at 00:30):
I'm not sure if this is an IG publisher or template issue...if someone can direct me I'm happy to log a GitHub issue against the relevant repo
Grahame Grieve (Aug 18 2021 at 00:43):
probably the IG publisher
Lloyd McKenzie (Aug 18 2021 at 00:56):
I think that's appropriate - it's a link external to this specification
Jose Costa Teixeira (Aug 18 2021 at 09:14):
I think this is because of some changes in the template - there was a css that added those icons to any external link. I'm not sure we caught all the places where that icon is now duplicate.
Max Masnick (Aug 18 2021 at 11:53):
@Jose Costa Teixeira do I need to log a GitHub issue?
Jose Costa Teixeira (Aug 18 2021 at 11:59):
I don't know where this comes from. The base template seems fins. so this could be an issue on the HL7 template
John Moehrke (Aug 18 2021 at 12:24):
it shows up in the IHE template too image.png
Jose Costa Teixeira (Aug 18 2021 at 14:23):
oh, then it is in the base template :)
Lloyd McKenzie (Aug 18 2021 at 16:10):
Oh, missed that this was a duplicate. That will be in the publisher, not the template, as the publisher injects the yellow bar
Jose Costa Teixeira (Aug 18 2021 at 16:26):
and the template adds the other icon - which one do we keep?
John Moehrke (Aug 18 2021 at 18:14):
oh, my base template IG did not have it
Lloyd McKenzie (Aug 18 2021 at 18:59):
We keep the template one. The publisher should no longer be adding that icon anywhere.
Lloyd McKenzie (Aug 18 2021 at 18:59):
So we'll need to submit pull requests to fix the publisher wherever it's still spitting out that icon
Grahame Grieve (Aug 18 2021 at 19:37):
is the template correct now? It was adding it in error., or missing it in places. But you can't just remove this, since this code runs on old IGs as well
Last updated: Apr 12 2022 at 19:14 UTC
