FHIR Chat · Errors in Differential View -- USCore and Plan-Net

Stream: IG creation

Topic: Errors in Differential View -- USCore and Plan-Net

Saul Kravitz (Jun 04 2020 at 15:32):

The differential view does not appear to correctly highlight changes in cardinality.
Look at the PractitionerRole resource/profile in R4[http://hl7.org/fhir/R4/practitionerrole.html], USCore [http://hl7.org/fhir/us/core/STU3/StructureDefinition-us-core-practitionerrole.html], and Plan-Net [https://build.fhir.org/ig/HL7/davinci-pdex-plan-net/StructureDefinition-plannet-PractitionerRole.html]

Here is R4:
image.png

Here is USCore differential (partial): Note that cardinalities for specialty and code have changed, but are not highlighted as changed.
image.png

Here is the Differential view for part of Plan-Net PractitionerRole (based on R4). Same issue. Cardinalities have changed, but not highlighted.
image.png

Saul Kravitz (Jun 09 2020 at 13:38):

I created an IG Publisher issue for this one -- https://github.com/HL7/fhir-ig-publisher/issues/106
Is that preferred over whining via zulip?

Jose Costa Teixeira (Jun 09 2020 at 14:12):

the change seems to be detected (the dots are in black, not grey), but not covering the entire text

Jose Costa Teixeira (Jun 09 2020 at 14:16):

image.png

Saul Kravitz (Jun 09 2020 at 18:02):

@Jose Costa Teixeira -- your eyes are better than mine!

Grahame Grieve (Jun 09 2020 at 23:31):

where did you get your us core screen shot from? I see

image.png

Grahame Grieve (Jun 09 2020 at 23:43):

and I agree that the specialty output is wrong in pdex-plan-net but when I tried to run it locally:

Run Sushi on C:\work\org.hl7.fhir.igs\davinci-pdex-plan-net                      (00:00.0918)
Sushi: info  Running SUSHI v0.12.7                                               (00:01.0357)
Sushi: info  Current FSH tank conforms to an IG Publisher context. Output will be adjusted accordingly. (00:01.0358)
Sushi: error No package.json in FSH definition folder.                           (00:01.0361)
Sushi couldn't be run. Complete output from running Sushi :                      (00:01.0370)
Note: Check that Sushi is installed correctly ("npm install -g fsh-sushi". On windows, get npm from https://www.npmjs.com/get-npm) (00:01.0370)
Exception: Process exited with an error: 1 (Exit value: 1)                       (00:01.0370)

Chris Moesel (Jun 10 2020 at 01:53):

Are you sure your local copy of davinci-pdex-plan-net is right (e.g., it's not missing any files)? I definitely see a package.json in the fsh folder. I pulled down the latest from master and ran SUSHI and it worked fine. I tried running the publisher too, but it didn't even try to run SUSHI, so I couldn't test it using the publisher integration. Did something change there? Shouldn't it automatically run SUSHI if there is a fsh folder?

Grahame Grieve (Jun 10 2020 at 02:11):

i see both a fsh and a fsh_ folder. The fsh_ folder looks like what fsh should be.

Chris Moesel (Jun 10 2020 at 02:19):

Hmmm... Not sure what that's about. GitHub shows only the fsh folder: https://github.com/HL7/davinci-pdex-plan-net

You might try blowing away your local davinici-pdex-plan-net and cloning it again from scratch.

Grahame Grieve (Jun 10 2020 at 06:58):

well that worked, though I don't know why. Found and fixed the underlying issue. It's existed forever

Saul Kravitz (Jun 10 2020 at 18:58):

Thanks!

Last updated: Apr 12 2022 at 19:14 UTC

Main menu

FHIR Chat · Errors in Differential View -- USCore and Plan-Net · IG creation