Stream: IG creation
Topic: Error from IG dependency
Sarah Gaunt (Nov 25 2020 at 05:22):
I get an error when I include an example for an ODH profile: Internal error: Could not match discriminator ([code.coding.code]) for slice Observation.component:odh-IsCurrentJob in profile http://hl7.org/fhir/us/odh/StructureDefinition/odh-PastOrPresentJob - the discriminator [code.coding.code] does not have fixed value, binding or existence assertions
This is an issue with the published ODH profile, they are aware of it, and are working on fixing it. Obviously it's not going to get fixed and published before we go to ballot. What is the best course of action? Should I just remove the example so that I get rid of the error in the IG and then put it back in before publication?
Grahame Grieve (Nov 25 2020 at 06:10):
does the error have more impact other than just appearing in the QA?
Sarah Gaunt (Nov 25 2020 at 06:21):
What do you mean "more impact"?
Lloyd McKenzie (Nov 25 2020 at 23:33):
Is it going to impact the ability of the balloter to understand what's going on? Are all of the examples you're producing actually correct?
Sarah Gaunt (Nov 26 2020 at 01:10):
I don't think it will impact the ability of the balloter to understand what is going on. The only issue is that there are currently no examples in the ODH spec so our examples are all our implementers have to go from. Having said that, I don't think they are needed for ballot as this isn't new in this version of the IG.
As far as I know the examples are correct - it's hard to tell when you get an "internal error" because the actual profile you are trying to validate against is not valid. That's the point of being able to validate against a profile - to make sure your examples are correct! :neutral:
I would be fine removing the examples for ballot. The commenters aren't reviewing the ODH profiles, they are reviewing the eCR profiles (and luckily the ODH profiles are optional in eCR).
Grahame Grieve (Nov 26 2020 at 02:22):
the point of the QA is to improve the IG. It's not a goal in it's own right. if the IG is better because content is in there, and the QA is wrong about it, I'd rather have the content in there
Sarah Gaunt (Nov 26 2020 at 03:02):
Well, the QA isn't wrong. The actual profile is wrong.
But the IG is definitely better with the the example there.
Grahame Grieve (Nov 26 2020 at 03:02):
keep it in there then
Sarah Gaunt (Nov 26 2020 at 03:05):
Shall do.
Last updated: Apr 12 2022 at 19:14 UTC
