Stream: IG creation
Topic: ECR Review
Grahame Grieve (Aug 17 2018 at 03:30):
@Sarah Gaunt you have one broken link, to a cql file - can you comment on that?
Grahame Grieve (Aug 17 2018 at 03:31):
also, lots of errors in ecr-bundle-knowledge-distribution.xml
Sarah Gaunt (Aug 17 2018 at 03:38):
That is all in @Kanwarpreet Sethi's stuff. It will be fixed before ballot deadline.
Grahame Grieve (Aug 17 2018 at 03:42):
ok thx
Grahame Grieve (Aug 17 2018 at 03:43):
kp hasn't got long... deadline is officially 24 hours away...
Sarah Gaunt (Aug 17 2018 at 04:31):
24 HOURS! I thought we had until midnight on the 19th? US time
Grahame Grieve (Aug 17 2018 at 04:32):
that's what I ran
Sarah Gaunt (Aug 17 2018 at 04:33):
What does "that's what I ran" mean?
Grahame Grieve (Aug 17 2018 at 04:33):
wrong topic. I should have said: http://wiki.hl7.org/index.php?title=FHIR_Ballot_Prep - 17th it is. But I actually made it 18th anyway
Sarah Gaunt (Aug 17 2018 at 04:34):
Great. I did not know that. I thought the final content deadline for the FHIR IGs was the same as the final content deadline in the HL7 publishing calendar.
Grahame Grieve (Aug 17 2018 at 04:35):
it should be the same. I don't know why it's different
Lloyd McKenzie (Aug 17 2018 at 04:35):
It's different because when we set the FHIR schedule back in May, you indicated you needed more time. HL7 publishing calendar is driven by V3/CDA timelines
Sarah Gaunt (Aug 17 2018 at 04:36):
Crap
Sarah Gaunt (Aug 17 2018 at 04:36):
I thought there was only one schedule
Sarah Gaunt (Aug 17 2018 at 04:37):
So it's Friday midnight - US time?
Grahame Grieve (Aug 17 2018 at 04:37):
apparently we are not world class at communicating things to our editors
Grahame Grieve (Aug 17 2018 at 04:38):
see https://chat.fhir.org/#narrow/stream/9-committers/subject/Ballot.20Freeze (which stream committers are required to keep up with...)
Sarah Gaunt (Aug 17 2018 at 04:40):
For some reason I thought that stream was about non-IG content.
So we have until midnight our time (AUS) on Sunday? Totally confused now.
Grahame Grieve (Aug 17 2018 at 04:40):
officially 7pm
Sarah Gaunt (Aug 17 2018 at 04:41):
Sunday?
Grahame Grieve (Aug 17 2018 at 04:41):
y
Sarah Gaunt (Aug 17 2018 at 04:42):
That's like 48 hours, not 24 hours. just means I can't go jetskiing tomorrow.. 29 here today!
Grahame Grieve (Aug 17 2018 at 04:43):
you're just making me happy...
Sarah Gaunt (Aug 17 2018 at 04:47):
Ok, so to tell my US dudes - deadline is Sunday 19th August, 5am. Just to be clear.
Grahame Grieve (Aug 19 2018 at 23:33):
@Sarah Gaunt this is weird:
-tx cache miss: $validate {urn:oid:1.0.3166.1#FJI: "Fiji"}: "null" for Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.3, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.3, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.3, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.3, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.114222.4.5.300, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.3, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:2.16.840.1.113883.6.92, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1, Include 1 codes from urn:oid:1.0.3166.1,
Grahame Grieve (Aug 19 2018 at 23:33):
looks to me like this value set is wrong
Sarah Gaunt (Aug 19 2018 at 23:38):
What do you mean "wrong"?
Grahame Grieve (Aug 19 2018 at 23:39):
well, why does it have so many includes with 1 code each? there should only be one include for each system...
Sarah Gaunt (Aug 19 2018 at 23:39):
It's this value set: https://phinvads.cdc.gov/vads/ViewValueSet.action?id=9CE75E17-176B-DE11-9B52-0015173D1785
I can fix it if it is wrong, but what is wrong with it?
Grahame Grieve (Aug 19 2018 at 23:40):
where did you get the FHIR version from?
Sarah Gaunt (Aug 19 2018 at 23:40):
Oh - didn't know it mattered - that's just the export out of trifolia
Grahame Grieve (Aug 19 2018 at 23:41):
well, it will render nicer for the reviewers. it doesn't mean anything different. @Sean McIlvenna should fix the trifolia export to be nice to revieweres
Sarah Gaunt (Aug 19 2018 at 23:41):
Hmmm, it may not be his fault - I had to add teh expansion I think - to get it to not error
Grahame Grieve (Aug 19 2018 at 23:42):
you shouldn't need to do that, and I'm not sure you should anyway
Sarah Gaunt (Aug 19 2018 at 23:42):
What do you mean by "render nicer for reviewers" - it looks fine when I look at the value set page?
Sarah Gaunt (Aug 19 2018 at 23:43):
Or are you saying there should be 2 lists - one ofor each code system?
Sarah Gaunt (Aug 19 2018 at 23:44):
I had major problems with value sets - I was getting that "can't unmarshall" error - adding the expansion fixed that problem.
Grahame Grieve (Aug 19 2018 at 23:44):
adding the expansion might hide the problem but it just kicks the can down the road. we
Grahame Grieve (Aug 19 2018 at 23:45):
we'll leave it as is for now, but it would be better if we don't have explicit expansions next time
Sarah Gaunt (Aug 19 2018 at 23:45):
Ok - well I'll fix it in ballot then. I'll make a comment to fix it.
Sarah Gaunt (Aug 19 2018 at 23:46):
I need to figure out how to do value sets properly anyway - at least value sets that don't use a standard code system - I had nothing but problems with them.
Grahame Grieve (Aug 20 2018 at 00:58):
so, @Sarah Gaunt I'm not seeing an actual list of changes anywhere in the ecr IG?
Sarah Gaunt (Aug 20 2018 at 01:00):
There is this: http://build.fhir.org/ig/HL7/case-reporting/history.html
Sarah Gaunt (Aug 20 2018 at 01:00):
I guess I can add some more info to it - like point to the Gforge tracker...
Grahame Grieve (Aug 20 2018 at 01:02):
well what I want to see is something like this: build.fhir.org/history.html - if somenone has read ecr before, what are the big things that have changed that they need to know about (without being downed by lots of tasks about typos etc)
Grahame Grieve (Aug 20 2018 at 01:02):
also, a question from me that doesn't need putting in the guide: are the page names stable enough that a page comparison link is worthwhile? (like at the foot of every fhir page)
Sarah Gaunt (Aug 20 2018 at 01:04):
I changed the names of almost every profile, does that answer your question. They weren't meaningful enough for my liking in the for comment ballot.
Grahame Grieve (Aug 20 2018 at 01:04):
well, that sure answers it.
Sarah Gaunt (Aug 20 2018 at 01:04):
:)
Grahame Grieve (Aug 20 2018 at 01:04):
that's a first good thing to put in the change notes...
Sarah Gaunt (Aug 20 2018 at 01:04):
I will knock something up - give me 30 mins
Grahame Grieve (Aug 20 2018 at 01:04):
thanks
Rob Hausam (Aug 20 2018 at 01:09):
I don't suppose there a way to make this a bit easier to put together? - the only thing I've actually thought of is gettiong a download from GForge to at least start.
Grahame Grieve (Aug 20 2018 at 01:10):
I'm looking for judgement from the editor here... anyone can go look in gforge and get overwhelmed... sorry
Sarah Gaunt (Aug 20 2018 at 01:25):
Ignoring the bad formatting - is this ok?
pasted image
Grahame Grieve (Aug 20 2018 at 01:27):
yep that's the sort of thing I'm looking for
Sarah Gaunt (Aug 20 2018 at 01:27):
Most of the changes weren't based on GForge comments - they were aligning the FHIR with the published CDA IGs. And basically finishing off the FHIR IG - becuse the for comment one was just that "for comment" and not complete...
Sarah Gaunt (Aug 20 2018 at 01:28):
Ok will commit.
Sarah Gaunt (Aug 20 2018 at 01:29):
Why do I have changes in my txCache files, every single time I run a local build? (not an important question, just curious)
Grahame Grieve (Aug 20 2018 at 01:30):
cause I haven't fully nailed the cache management yet. Getting close...
Sarah Gaunt (Aug 20 2018 at 01:30):
Cool
Sarah Gaunt (Aug 20 2018 at 01:35):
Committed history - let me know if you need anything else...
Grahame Grieve (Aug 20 2018 at 01:38):
ok sure thanks
Grahame Grieve (Aug 20 2018 at 16:20):
@Sarah Gaunt I still do not see any history notes...?
Sarah Gaunt (Aug 20 2018 at 17:23):
http://build.fhir.org/ig/HL7/case-reporting/history.html
Sarah Gaunt (Aug 20 2018 at 17:30):
The link is at the bottom of the page. In the footer
Grahame Grieve (Aug 21 2018 at 02:58):
@Sarah Gaunt let me know if assigning v 0.2.0 to this publication is a problem
Sarah Gaunt (Aug 21 2018 at 03:00):
Nope! Assign away...
Sarah Gaunt (Aug 23 2018 at 21:41):
@Grahame Grieve our IG has a link that doesn't work. On this page: http://hl7.org/fhir/us/ecr/2018Sep/StructureDefinition-eicr-composition.html - this link: http://hl7.org/fhir/STU3profiling.html#representation
I tried this on another IG and it doesn't work either - is this an issue on your end or on our end?
Sarah Gaunt (Aug 23 2018 at 21:53):
Also, are we allowed to make any minor changes - we have noticed something and would like to add a paragraph to explain so that people don't get the the wrong end of the stick...
Grahame Grieve (Aug 23 2018 at 21:53):
only if it's desparately wrong
Grahame Grieve (Aug 23 2018 at 21:53):
freeze was a long time ago
Sarah Gaunt (Aug 23 2018 at 21:54):
I know... Client thinks it is desperately wrong! It would just be one sentence explaining something...
Sarah Gaunt (Aug 23 2018 at 21:56):
What about that bad link - it's on every profile page...
Grahame Grieve (Aug 23 2018 at 21:56):
it's in the source ig
Grahame Grieve (Aug 23 2018 at 21:56):
where else did you see it?
Sarah Gaunt (Aug 23 2018 at 21:56):
Just randomly picked another build: http://build.fhir.org/ig/udaychandrupatla/au-fhir-base/StructureDefinition-au-medication.html
Sarah Gaunt (Aug 23 2018 at 22:07):
It is this in sd.html: '''<a href="{{site.data.fhir.path}}profiling.html#representation">Description of Profiles, Differentials, and Snapshots</a>'''
I've just checked VhDir and that works in that IG, but not in ours? (I looked at their sd.html and the href is exactly the same)
Sarah Gaunt (Aug 23 2018 at 22:08):
Only difference I can see is that VhDir is R4 and ECR is R3?
Grahame Grieve (Aug 23 2018 at 22:12):
it's a bug in the IG publisher. no one has picked it up before
Grahame Grieve (Aug 23 2018 at 22:12):
difference is in the spec path in the ig.json file
Sarah Gaunt (Aug 23 2018 at 22:13):
Ok - is it something that is fixable before this goes out to the commenters - they will pick it up for sure and make a billion comments on it! :joy:
Last updated: Apr 12 2022 at 19:14 UTC
