Stream: IG creation
Topic: DEQM review
Grahame Grieve (Aug 17 2018 at 03:33):
@Eric Haas DEQM has a lot of broken links in the build. where are with this?
Grahame Grieve (Aug 17 2018 at 03:34):
also, Unable to resolve resource 'http://terminology.hl7.org/ValueSet/v2-2.7-0360' -->looks like an error I need to investigate?
Grahame Grieve (Aug 17 2018 at 03:35):
? The extension http://hl7.org/fhir/tooling/StructureDefinition/r4ModifierReason is unknown, and not allowed here - have you looked at this?
Bryn Rhodes (Aug 17 2018 at 03:43):
@Grahame Grieve > Unable to resolve resource 'http://terminology.hl7.org/ValueSet/v2-2.7-0360'
Bryn Rhodes (Aug 17 2018 at 03:44):
Yes, I was surprised by that one since I thought it would be okay to reference, the tooling would just resolve.
Grahame Grieve (Aug 17 2018 at 03:53):
oh - DEQM says it's based on 3.0.1 - so you must use a 3.0.1 reference. 'http://terminology.hl7.org/ValueSet/v2-2.7-0360' is an R4 change
Eric Haas (Aug 17 2018 at 03:54):
I will fix them. lots of moving parts right now
Grahame Grieve (Aug 17 2018 at 03:54):
ok. I was just doing a review before it's too late.
Eric Haas (Aug 17 2018 at 03:55):
we have the same dual publishing issued as CRD except the main guide is R3 and the accessory one is R4
Eric Haas (Aug 17 2018 at 04:06):
@Grahame Grieve I need administrative privileges for https://github.com/HL7/davinci-deqm-r4 OR can you:
- set up the autopublisher to run this.
- add Bryn to the list of committers.
- need a npm package name for this one. see this chat https://chat.fhir.org/#narrow/stream/128-DaVinci/subject/DEQM-R4
I don't have any settings priveleges
Grahame Grieve (Aug 17 2018 at 04:09):
ok
Eric Haas (Aug 17 2018 at 04:09):
so I am confused about the vocab references: "http://terminology.hl7.org/" is only for R4 artifacts?
Eric Haas (Aug 17 2018 at 04:10):
that extension: http://hl7.org/fhir/tooling/StructureDefinition/r4ModifierReason is build generated??? is not in my source as far as I can tell @Bryn Rhodes ??
Bryn Rhodes (Aug 17 2018 at 04:10):
@Eric Haas I already set up the davinci-deqm-r4 repro to autopublish.
Eric Haas (Aug 17 2018 at 04:10):
for R3 stuff we use the old vocab paths?
Grahame Grieve (Aug 17 2018 at 04:11):
y
Eric Haas (Aug 17 2018 at 04:11):
@Bryn I didn't see your name on the committers list sorry
Bryn Rhodes (Aug 17 2018 at 04:12):
No worries, it's available here
Eric Haas (Aug 17 2018 at 04:12):
@GG never mind Bryn did it - I just am in the dark on collaborator on that repro for some reason
Eric Haas (Aug 17 2018 at 04:13):
still need an npm name
Bryn Rhodes (Aug 17 2018 at 04:13):
Not sure where the r4ModifierReason extension is coming from.
Bryn Rhodes (Aug 17 2018 at 04:13):
Is that on one of the measure/library profiles?
Eric Haas (Aug 17 2018 at 04:14):
@Bryn it pops up for the Subscription modifier extension.
Bryn Rhodes (Aug 17 2018 at 04:14):
Huh.
Eric Haas (Aug 17 2018 at 04:15):
The spreadsheet generates the SD files and it is slipped to the definition
Bryn Rhodes (Aug 17 2018 at 04:15):
My guess is that modifier extensions need a modifier reason and they have to use the r4ModifierReason extension to provide it?
Bryn Rhodes (Aug 17 2018 at 04:16):
Is there an STU3 equivalent and since the tooling is doing it it's defaulting to R4?
Eric Haas (Aug 17 2018 at 04:17):
Yes and I tried that in the R3 Build and got that extension error message. Tried a new column called "Modifier Reason" but no dice. I will give it a whirl in R4 though
Eric Haas (Aug 17 2018 at 04:18):
I need to spend an hour on VHDIR and and HOUR on Obervation will come back to it though
Grahame Grieve (Aug 17 2018 at 04:18):
that issue is definitely mine
Grahame Grieve (Aug 17 2018 at 05:26):
ok fixed
Grahame Grieve (Aug 19 2018 at 22:35):
@Eric Haas @Bryn Rhodes I do not understand this in the ig.json for deqm R3:
{ "location" : "http://hl7.org/fhir/us/davinci-deqm", "name" : "deqm", "version" : "current" }
Bryn Rhodes (Aug 19 2018 at 23:26):
I don’t understand that either, it’s probably a left over from trying to get the dependencies between versions to work.
Grahame Grieve (Aug 19 2018 at 23:28):
the 2 guides are dependent on each other? that's not going to work
Grahame Grieve (Aug 20 2018 at 01:38):
I see a number of broken links, some that look like a problem?
Bryn Rhodes (Aug 20 2018 at 03:44):
I see three broken links, but they all resolve when I hit them in a browser.
Bryn Rhodes (Aug 20 2018 at 03:45):
http://hl7.org/fhir/STU3/subscription.html, http://hl7.org/fhir/STU3/resourcelist.html, and http://hl7.org/fhir/us/core/index.html
Grahame Grieve (Aug 20 2018 at 03:46):
the other deqm guide
Bryn Rhodes (Aug 20 2018 at 03:58):
Reviewing those, they all look like holdovers from the STU3 version (which was copied to create the R4 version) and don't have relevant content (they're not linked from the homepage). The only thing the R4 version contains is R4 versions of the profiles, and those links all seem to be working.
Eric Haas (Aug 20 2018 at 16:46):
"the 2 guides are dependent on each other? that's not going to work" I tried to bring this up before but you are too busy. here is my summary: https://chat.fhir.org/#narrow/stream/128-DaVinci/subject/DEQM-R4
I did the best I could and put in a bunch of todo links instenad.
I only had 3 bad links in the STU3 guide and I was too exhausted to figure out why, like Bryn say they resolved fine. RE the R4 guide - what do I do about that if anything?
Eric Haas (Aug 20 2018 at 16:52):
Wow I must have be really tired to have missed those links errors. They are easy to fix, I did not clean up the ig as thoroughlye as I thought when I copied over.
Grahame Grieve (Aug 20 2018 at 21:11):
so is there any content dependency between either or is just for referencing?
Eric Haas (Aug 20 2018 at 21:37):
just references
I tried using {{site.data.fhir.deqmstu3}} or {{site.data.fhir.deqm}} but that did not work.
deqm-r4 only has a single reference to deqm (stu3). I removed the direct links from deqm (stu3) and replace with the r4todo link.
so right now deqm-r4 is only a set of R4 profiles that represent the same profiles in deqm (stu3). IMO its not crucial content for the ballot because there in no new content (only the structural changes bewteen versions)
Grahame Grieve (Aug 20 2018 at 21:39):
ok
Grahame Grieve (Aug 20 2018 at 21:39):
we'll have to figure out a nice way to handle this in the future
Eric Haas (Aug 20 2018 at 21:39):
I think Lloyd has done that already.
Grahame Grieve (Aug 20 2018 at 21:40):
he's done something different....
Grahame Grieve (Aug 20 2018 at 21:40):
I don't know whether it solves the problem or not
Eric Haas (Aug 20 2018 at 21:40):
k
Grahame Grieve (Aug 21 2018 at 02:40):
hey @Eric Haas I'm just making sure I've got the deqm guide correct. the R4 guide says:
Grahame Grieve (Aug 21 2018 at 02:40):
DaVinci Data Exchange For Quality Measures R4 Artifacts. The Profiles and CapabilityStatements in this guide are used and referenced in the Data Exchange For Quality Measures Implementation Guide
Grahame Grieve (Aug 21 2018 at 02:41):
which is a reference to the R3 guide. but I can't find where in the R3 guide this actually happens?
Bryn Rhodes (Aug 21 2018 at 13:07):
That's the part we don't know how to do with the current tooling. It's supposed to be on this page: http://build.fhir.org/ig/HL7/davinci-deqm/profiles.html, but right now all we have is placeholders.
Eric Haas (Aug 21 2018 at 14:37):
Here is a screen shot showing where these links would be: Screen-Shot-2018-08-21-at-7.33.55-AM.png
Eric Haas (Aug 21 2018 at 14:38):
the file: /source/pages/_includes/link-list.md contains all the page links
Eric Haas (Aug 21 2018 at 14:39):
...
[DEQM Coverage (R4)]: r4todo.html
[DEQM Coverage (STU3)]: {{page.deqm_r3}}StructureDefinition-coverage-deqm.html
[DEQM Library (R4)]: r4todo.html
[DEQM Library (STU3)]: {{page.deqm_r3}}StructureDefinition-library-deqm.html
[DEQM Measure (R4)]: r4todo.html
...
Eric Haas (Aug 21 2018 at 14:41):
the r4todo.html would be replaced with [path to deqm-r4]StructureDefinition-[id].html
Eric Haas (Aug 21 2018 at 14:44):
does that make sense? And like I said before the important stuff for the ballot is the guidance in the stu3 deqm guide. These are just the R4 versions of only some the R3 profiles so not critical.
Bryn Rhodes (Aug 21 2018 at 22:12):
Looking at the content on the ballot site for deqm, the links to QI-Core and HEDIS are ballot links, but QI-Core isn't being balloted this cycle, and HEDIS IG will never be balloted, it's an NCQA IG.
Bryn Rhodes (Aug 21 2018 at 22:13):
For example, http://hl7.org/fhir/us/davinci-deqm/2018Sep/STU3/profiles.html
Bryn Rhodes (Aug 21 2018 at 22:13):
The link to QI-Core Patient is: http://hl7.org/fhir/2018Sep/ig/cqframework/qi-core/StructureDefinition-qicore-patient.html
Bryn Rhodes (Aug 21 2018 at 22:14):
But it should be the STU3 QI-Core link.
Grahame Grieve (Aug 22 2018 at 00:00):
fixing it.
Grahame Grieve (Aug 22 2018 at 00:01):
so I think I won't fix the ballot guide...
Grahame Grieve (Aug 22 2018 at 00:01):
(for the R4 links)
Eric Haas (Aug 22 2018 at 16:40):
Thanks for catching this @Bryn Rhodes. @Grahame Grieve did you update the links or is this a ballot comment?
Grahame Grieve (Aug 22 2018 at 19:55):
I will fix those
Grahame Grieve (Aug 22 2018 at 22:22):
fixed. uploading now
Eric Haas (Aug 23 2018 at 20:36):
ty
Bryn Rhodes (Mar 02 2020 at 04:12):
Were you ever able to get this to work in an R4 guide @Eric Haas ? I'm trying it in QI Core and getting:
eld-18: Must have a modifier reason if isModifier = true [(isModifier.exists() and isModifier) implies isModifierReason.exists()]
Bryn Rhodes (Mar 02 2020 at 04:12):
I've added a "Modifier Reason" column to the extension definition, but wherever I use the extension as a modifier I get this error.
Eric Haas (Mar 02 2020 at 19:04):
I don't recall using an ismod anywhere. I kind of avoid them if possible... but i would recommend converting the SD from spreadsheet to XML and trying it as it may be a spreadsheet limitation.
Last updated: Apr 12 2022 at 19:14 UTC
