FHIR Chat · Adding ExampleScenario · IG creation

Stream: IG creation

Topic: Adding ExampleScenario


view this post on Zulip Jose Costa Teixeira (Jul 21 2020 at 07:28):

I am currently getting this

Exception in thread "main" java.lang.Error: The resource type "ExampleScenario" does not implement the property "description"
        at org.hl7.fhir.r5.model.ExampleScenario.getDescriptionElement(ExampleScenario.java:4604)
        at org.hl7.fhir.igtools.publisher.Publisher.getDesc(Publisher.java:6289)
        at org.hl7.fhir.igtools.publisher.Publisher.genEntryItem(Publisher.java:6180)
        at org.hl7.fhir.igtools.publisher.Publisher.genResourceReferencesList(Publisher.java:6270)
        at org.hl7.fhir.igtools.publisher.Publisher.generateResourceReferences(Publisher.java:6226)
        at org.hl7.fhir.igtools.publisher.Publisher.generateResourceReferences(Publisher.java:6040)
        at org.hl7.fhir.igtools.publisher.Publisher.generateSummaryOutputs(Publisher.java:5412)
        at org.hl7.fhir.igtools.publisher.Publisher.generate(Publisher.java:4708)
        at org.hl7.fhir.igtools.publisher.Publisher.createIg(Publisher.java:859)
        at org.hl7.fhir.igtools.publisher.Publisher.execute(Publisher.java:708)
        at org.hl7.fhir.igtools.publisher.Publisher.main(Publisher.java:7835)

I'm not sure if this is something I broke or if we need to do something in the publisher for ExampleScenario.

view this post on Zulip Jose Costa Teixeira (Jul 21 2020 at 07:30):

the rendering is taken up entirely by the template, so the publisher doesn't need to do anything there. Perhaps this is a new check? Or something I am missing.

view this post on Zulip Jose Costa Teixeira (Jul 21 2020 at 07:30):

for context: I'm starting to add ExampleScenario to the base template

view this post on Zulip Jose Costa Teixeira (Jul 21 2020 at 08:50):

@Grahame Grieve any idea what could be the reason?

view this post on Zulip Grahame Grieve (Jul 21 2020 at 10:44):

well, it's a code issue - create a task for me to fix it against the publisher.

view this post on Zulip Jose Costa Teixeira (Jul 21 2020 at 10:49):

Grahame Grieve said:

well, it's a code issue - create a task for me to fix it against the publisher.

https://github.com/HL7/fhir-ig-publisher/issues/136
Thanks!

view this post on Zulip Jose Costa Teixeira (Aug 11 2020 at 17:24):

@Grahame Grieve is this something I can crawl through the code and fix? If you tell me what is the cause for the issue, I can try to make a PR.

view this post on Zulip Jose Costa Teixeira (Aug 13 2020 at 20:10):

I think i found it. There seems to be a regression from 1.1.2 to 1.1.3. Here:

view this post on Zulip Jose Costa Teixeira (Aug 13 2020 at 20:11):

image.png
it no longer checks if the resource has a description before trying to get it.

view this post on Zulip Jose Costa Teixeira (Aug 13 2020 at 20:12):

I could change it, but I do not know what and how to initialize the PrimitiveType if the resource does not have definition

view this post on Zulip Jose Costa Teixeira (Aug 13 2020 at 20:13):

https://github.com/HL7/fhir-ig-publisher/compare/1.1.2...1.1.3#diff-8ba944eececf281bdf40b620083d2e9eL6266

view this post on Zulip Jose Costa Teixeira (Aug 13 2020 at 20:14):

I think the current code is now this
https://github.com/HL7/fhir-ig-publisher/blob/master/org.hl7.fhir.publisher.core/src/main/java/org/hl7/fhir/igtools/publisher/Publisher.java#L6355

view this post on Zulip Jose Costa Teixeira (Aug 13 2020 at 20:15):

can the if statement be restored (and perhaps an else is needed) ?

view this post on Zulip Jose Costa Teixeira (Aug 13 2020 at 20:18):

I just checked and this fix allows my IG to build again

view this post on Zulip Jose Costa Teixeira (Aug 13 2020 at 20:54):

@Grahame Grieve if you could please look at this the next time you get your hands on publisher.java...

view this post on Zulip Grahame Grieve (Aug 18 2020 at 04:16):

I'm not sure what happened there - fixed next release

view this post on Zulip Jose Costa Teixeira (Aug 18 2020 at 22:03):

thank you


Last updated: Apr 12 2022 at 19:14 UTC