Stream: tooling
Topic: Validator calls /ValueSet/$validate-code without a ValueSet
Michael Lawley (May 11 2021 at 21:31):
It appears that the validator sometimes (e.g., when validating a ValueSet that is defined extensionally) calls /ValueSet/$validate-code without specifying a ValueSet and that tx.fhir.org behaves as if /CodeSystem/$validate-code were called, but other terminology servers do not.
It appears that tx.fhir.org is wrong in this case (and thus the validator is behaving badly) since the normative definition of /ValueSet/$validate-code explicitly states:
If the operation is not called at the instance level, one of the in parameters url, context or valueSet must be provided.
Grahame Grieve (May 12 2021 at 12:33):
how to reproduce this?
Michael Lawley (May 13 2021 at 04:25):
I think this description should help: https://github.com/hapifhir/org.hl7.fhir.core/issues/494
Michael Lawley (May 13 2021 at 04:26):
I believe it should just be enough to change the call to CodeSystem/$validate-code in these batch requests
Alejandro Metke (May 13 2021 at 04:30):
I think you still need to add the url parameter, but when calling CodeSystem/$validate-code that is the same as the system in the coding.
Alejandro Metke (May 13 2021 at 04:32):
The spec for CodeSystem/$validate-code says 'If the operation is not called at the instance level, one of the parameters "url" or "codeSystem" must be provided.'
Alejandro Metke (May 13 2021 at 04:35):
@Grahame Grieve easiest way to reproduce is to create a simple extensional VS with SCT codes and run the publisher with -tx https://r4.ontoserver.csiro.au/fhir. I did this with a FSH project.
Michael Lawley (May 13 2021 at 04:37):
hmm, a pity -- if you pass in a Coding, then surely you want to validate against the system and shouldn't need to also specify a value for url
Alejandro Metke (May 13 2021 at 04:40):
Yes, I agree!
Grahame Grieve (May 13 2021 at 22:28):
easiest way to reproduce is to create a simple extensional VS with SCT codes and run the publisher with -tx https://r4.ontoserver.csiro.au/fhir. I did this with a FSH project
This is hardly quick. Do you want to send me the project?
Alejandro Metke (May 14 2021 at 00:53):
Grahame Grieve said:
easiest way to reproduce is to create a simple extensional VS with SCT codes and run the publisher with -tx https://r4.ontoserver.csiro.au/fhir. I did this with a FSH project
This is hardly quick. Do you want to send me the project?
Fair enough. Here is the project ExampleIG.zip.
I'm sure you already know this, but just for completeness, what you need to do is unzip it and then:
sushi .
./_updatePublisher.sh
./_genonce.sh -tx https://r4.ontoserver.csiro.au/fhir
The warnings will be on output/qa.html.
Grahame Grieve (May 14 2021 at 02:59):
fixed next release
Last updated: Apr 12 2022 at 19:14 UTC
