FHIR Chat · docs / PR #73 Travis deploys · cds hooks/committers

Stream: cds hooks/committers

Topic: docs / PR #73 Travis deploys

Github Notifications (Jul 31 2017 at 01:34):

mattberther opened PR #73
from travis-deploys to master

@kpshek This is untested, but should do the job. I've already added the encrypted deploy key to travis (and to the repo here). Take a look through, and if you like it, merge it.

Please let me know if you have any questions.

Github Notifications (Jul 31 2017 at 01:34):

mattberther review_requested PR #73

Github Notifications (Jul 31 2017 at 01:34):

mattberther review_requested PR #73

Github Notifications (Aug 04 2017 at 17:30):

kpshek commented on PR #73

Thanks for putting this together @mattberther and sorry for the delay in reviewing!

Rather than modifying the existing deploy.shscript, can you make your changes in a new travis-deploy.sh script?

The reasons why I suggest this are:

• The deploy.sh comes from the upstream Slate project and when we upgrade to Slate 2.0, it will make the upgrade easier (the less we change the Slate code, the better)
• Keeping the existing deploy.sh will allow us to manually deploy (like we're doing today) if needed.

Github Notifications (Aug 06 2017 at 01:16):

mattberther synchronized PR #73

Github Notifications (Aug 06 2017 at 01:18):

mattberther commented on PR #73

Thanks for the feedback, @kpshek. Please review, and if you're comfortable, go ahead and merge.

Github Notifications (Aug 10 2017 at 16:03):

kpshek closed PR #73

Last updated: Apr 12 2022 at 19:14 UTC