FHIR Chat · docs / PR #453 Fix to prefetch example, for userId · cds hooks/committers

Stream: cds hooks/committers

Topic: docs / PR #453 Fix to prefetch example, for userId

Github Notifications (Dec 21 2018 at 15:27):

isaacvetter opened PR #453
from iss410-userId-resourcename-prefix to master

Fixes #410

The context.userId field is (somewhat recently) defined to contains the FHIR resource name and identifier. For example, this field should contain: Practitioner/123. This was done to explicitly support scenarios other than provider-facing, for example, the user could be Patient/456' or Person/789` (following the user-to-FHIR mapping) that SMART negotiated.

Because of this change, the prefetch example of Practitioner/{{context.userId}} would translate into Practitioner/Practitioner/123 as issue #410 points out.

This PR simply removes the "Practitioner/" string from the example, in lieu of the alternative, breaking changes suggested in #410.

Github Notifications (Dec 21 2018 at 15:27):

isaacvetter review_requested PR #453

Github Notifications (Dec 21 2018 at 15:27):

isaacvetter review_requested PR #453

Github Notifications (Dec 21 2018 at 15:27):

isaacvetter review_requested PR #453

Github Notifications (Dec 21 2018 at 15:37):

mattvarghese commented on PR #453

Aren't both the options "breaking" changes though?
That was my thinking when I suggested instead to rename to practitionerId, since then, the resource type is implied.

Github Notifications (Dec 21 2018 at 16:45):

mattvarghese commented on PR #453

Isaac explained this to me - I'm okay with going ahead with this plan.

Github Notifications (Dec 21 2018 at 17:01):

isaacvetter closed PR #453

Last updated: Apr 12 2022 at 19:14 UTC