Stream: cds hooks/committers
Topic: docs / PR #425 #232: Removed "user" from the request and ...
Github Notifications (Nov 07 2018 at 05:07):
brynrhodes opened PR #425
from issue/232-move-user-to-context to master
…ined hooks as "userId". Updated relevant examples, yaml, and removed the "user" prefetch token defined by the spec.
Github Notifications (Nov 07 2018 at 05:07):
brynrhodes review_requested PR #425
Github Notifications (Nov 07 2018 at 05:07):
brynrhodes review_requested PR #425
Github Notifications (Nov 07 2018 at 05:07):
brynrhodes review_requested PR #425
Github Notifications (Nov 07 2018 at 15:21):
kpshek edited PR #425
from issue/232-move-user-to-context to master
Removed "user" from the request and added it to each of the defined hooks as "userId". Updated relevant examples, yaml, and removed the "user" prefetch token defined by the spec.
Fixes #232
Github Notifications (Nov 07 2018 at 16:17):
isaacvetter commented on PR #425
@brynrhodes - why change from
usertouserId?The services in the wild that I've been seeing have been assuming that the element name won't change.
Github Notifications (Nov 07 2018 at 17:00):
@brynrhodes - why change from user to userId?
Thank you for catching this @isaacvetter. I actually missed that when reviewing. I'm not opposed to the renaming but we should capture the reasoning here for posterity.
Github Notifications (Nov 07 2018 at 18:01):
brynrhodes commented on PR #425
Yeah, I debated leaving it as user but it felt so inconsistent with the other hooks that I opted for the change, on the basis that it's a breaking change anyway, so now would be the time to make it.
Github Notifications (Nov 12 2018 at 22:27):
isaacvetter commented on PR #425
Fixes #307
Github Notifications (Nov 13 2018 at 00:18):
kpshek edited PR #425
from issue/232-move-user-to-context to master
Removed "user" from the request and added it to each of the defined hooks as "userId". Updated relevant examples, yaml, and removed the "user" prefetch token defined by the spec.
Fixes #232
Fixes #307
Github Notifications (Nov 13 2018 at 00:20):
Carrying over the comments from #421 now that those changes have been merged in:
@isaacvetter said:
Hey Kevin - I think that this user text strongly suggested that Patient facing use-cases are as supported as Practitioner facing use-cases; which I don't think is true.
While there's nothing stopping CDS Hooks from being used in a patient-facing scenario, it would make sense to communicate to the reader that provider-facing is primary.
Would you be willing to add a small amount of text to indicate this?
@kpshek said:
@isaacvetter - Can you suggest something concrete?
Our prior documentation referenced the Patient and RelatedPerson resources -- both of which are not providers. The name of this field is user (or soon to be userId) which further reinforces the expanded intention of this field.
Should this type of clarification be best specified in each hook? For instance, medication-prescribe should probably always be a Practitioner id rather than something more broad, right?
@brynrhodes said:
@kpshek @isaacvetter , I agree with Kevin's suggestion that this should be specified more concretely in the hook, I'm happy to add that to the changes there.
Github Notifications (Nov 13 2018 at 01:53):
brynrhodes synchronized PR #425
Github Notifications (Nov 13 2018 at 21:24):
kpshek synchronized PR #425
Github Notifications (Nov 13 2018 at 21:59):
kpshek closed PR #425
Last updated: Apr 12 2022 at 19:14 UTC
