Stream: cds hooks/committers
Topic: docs / PR #421 Clarify user documentation (fixes #220)
Github Notifications (Nov 02 2018 at 02:37):
kpshek opened PR #421
from issue/220-clarify-user-field to master
Github Notifications (Nov 02 2018 at 02:37):
kpshek review_requested PR #421
Github Notifications (Nov 02 2018 at 02:37):
kpshek review_requested PR #421
Github Notifications (Nov 02 2018 at 02:37):
kpshek review_requested PR #421
Github Notifications (Nov 02 2018 at 03:18):
kpshek edited PR #421
from issue/220-clarify-user-field to master
This fixes #220
Github Notifications (Nov 07 2018 at 16:16):
Actually, this documentation was removed by the change to move user to the hook context. I'm happy to apply this requested change on top of that PR
The way we would handle this would be to merge this PR in, and then resolve the conflicts with your PR by applying this change in there.
Github Notifications (Nov 07 2018 at 16:57):
kpshek synchronized PR #421
Github Notifications (Nov 07 2018 at 17:52):
@isaacvetter - Can you suggest something concrete?
Our prior documentation referenced the Patient and RelatedPerson resources -- both of which are not providers. The name of this field is
user(or soon to beuserId) which further reinforces the expanded intention of this field.Should this type of clarification be best specified in each hook? For instance, medication-prescribe should probably always be a Practitioner id rather than something more broad, right?
Github Notifications (Nov 07 2018 at 17:53):
kpshek synchronized PR #421
Github Notifications (Nov 07 2018 at 18:03):
brynrhodes commented on PR #421
@kpshek @isaacvetter , I agree with Kevin's suggestion that this should be specified more concretely in the hook, I'm happy to add that to the changes there.
Github Notifications (Nov 07 2018 at 18:41):
kpshek synchronized PR #421
Github Notifications (Nov 07 2018 at 18:49):
kpshek synchronized PR #421
Github Notifications (Nov 13 2018 at 00:16):
kpshek closed PR #421
Last updated: Apr 12 2022 at 19:14 UTC
