Stream: cds hooks/committers
Topic: docs / PR #392 link to the hooks specification correctly.
Github Notifications (Aug 06 2018 at 20:15):
isaacvetter opened PR #392
from link-to-hooks-correctly to master
Fixes #216 (I think)
Per the mkdocs relative linking documentation, I updated two links to the Hooks catalog / specification from broken, relative or fully qualified to relative markdown links.
These links should work in at least three published locations:
1) https://github.com/cds-hooks/docs/blob/master/docs/specification/1.0.md
2) https://cds-hooks.org/specification/1.0/
3) http://cds-hooks.hl7.org/ballots/2018May/specification/1.0/
Github Notifications (Aug 06 2018 at 20:15):
isaacvetter review_requested PR #392
Github Notifications (Aug 06 2018 at 20:15):
isaacvetter review_requested PR #392
Github Notifications (Aug 06 2018 at 20:15):
isaacvetter review_requested PR #392
Github Notifications (Aug 09 2018 at 17:49):
isaacvetter commented on PR #392
Thanks, @brettmarquard ! I wasn't sure how to test the http://cds-hooks.hl7.org/ballots/2018May/specification/1.0/, were you able to verify this as well?!?
Github Notifications (Aug 09 2018 at 22:14):
isaacvetter commented on PR #392
I _think_ that we can't ensure that these links work in the hl7.org site, without ensuring that the publishing of the hl7.org site matches the same directory structure as the other sites.
- https://github.com/cds-hooks/docs/blob/master/docs/specification/1.0.md
** Hooks.- https://cds-hooks.org/specification/1.0/
** mkdocs transforms the link to: <a href="../../hooks/">Hooks</a>- http://cds-hooks.hl7.org/ballots/2018May/specification/1.0/
** Needs to link to http://cds-hooks.hl7.org/ballots/2018May/hooks/, which would be the same as the mkdocs ../../hook/ relative link, so I think that we're good.Isaac
Github Notifications (Aug 09 2018 at 22:14):
isaacvetter synchronized PR #392
Github Notifications (Aug 13 2018 at 20:22):
isaacvetter closed PR #392
Last updated: Apr 12 2022 at 19:14 UTC
