Stream: cds hooks/committers
Topic: docs / PR #183 #171, #172, #173, #177: Changed Priority t...
Github Notifications (Mar 26 2018 at 14:44):
brynrhodes opened PR #183
from issues/171-172-173-177-fixes to master
…. Added Type column to all tables to split type out from description. Fixed several references to Patient.id (changed to context.patientId) and corrected prefetch-template documentation based on new context tokens. Also changed User.id to userId for consistency with hook context names.
Github Notifications (Mar 26 2018 at 14:44):
brynrhodes review_requested PR #183
Github Notifications (Mar 26 2018 at 14:44):
brynrhodes review_requested PR #183
Github Notifications (Mar 26 2018 at 15:25):
isaacvetter commented on PR #183
Hey Bryn,
It might complicate merging a bit, but I think you should also update the hooks pages to address #177.
Isaac
Github Notifications (Mar 26 2018 at 15:45):
isaacvetter commented on PR #183
Hey Bryn,
PR #181 is more targeted towards the context variable syntax change {{User.Id}} -> {{User}}.
Mind undoing those sets of changes from this PR?
Isaac
Github Notifications (Mar 26 2018 at 18:03):
brynrhodes synchronized PR #183
Github Notifications (Mar 26 2018 at 18:10):
brynrhodes synchronized PR #183
Github Notifications (Mar 26 2018 at 18:13):
brynrhodes synchronized PR #183
Github Notifications (Mar 26 2018 at 18:26):
isaacvetter commented on PR #183
Hey Bryn,
This is subtle; let me know if you disagree with the goal. You changed the html header level of the following header sections in docs/hooks/index.md -
+###hook-name-expressed-as-noun-verb
+### Workflow
+### ContextYour change made them consistent with the rest of the html headers on docs/hooks/index.md. Previously, they were consistent with the header levels on the individual hooks pages. My intent was to make the hooks.index.md page as a template for the hooks pages.
At this point, perhaps there's too much content on hooks/index.md for that to work.
Isaac
Github Notifications (Mar 26 2018 at 18:27):
isaacvetter commented on PR #183
Why is so much of the diff in hooks/index.md highlighted in red?
https://github.com/cds-hooks/docs/pull/183/files#diff-64ff89a786c99c7caf0aac385c90dfb2
Github Notifications (Mar 26 2018 at 18:35):
isaacvetter commented on PR #183
Is there an extra brace around the docs/hooks/medication-prescribe.md's example medications DSTU Bundle first MedicationOrder?
(This is probably my fault, not yours).
Github Notifications (Mar 26 2018 at 18:35):
kpshek synchronized PR #183
Github Notifications (Mar 26 2018 at 18:37):
kpshek synchronized PR #183
Github Notifications (Mar 26 2018 at 18:38):
isaacvetter synchronized PR #183
Github Notifications (Mar 26 2018 at 18:41):
Why is so much of the diff in hooks/index.md highlighted in red?
@isaacvetter - There was a missing
}in the preceding JSON example which was causing the parse issue. I've fixed that in c956457
Github Notifications (Mar 26 2018 at 18:49):
kpshek synchronized PR #183
Github Notifications (Mar 26 2018 at 18:50):
@isaacvetter - That JSON example was still a bit malformed. I fixed it and through it through a formatter (https://jsonformatter.curiousconcept.com/) in c7c8850
Github Notifications (Mar 26 2018 at 18:52):
kpshek synchronized PR #183
Github Notifications (Mar 26 2018 at 20:59):
brynrhodes commented on PR #183
@isaacvetter , I agree there's probably too much content to make the same page be a template, but I like the idea of a hook template. Should I add one to this PR or should that be a separate issue?
Github Notifications (Mar 27 2018 at 05:15):
isaacvetter commented on PR #183
Hey @brynrhodes ,
Undoubtedly a different issue, but perhaps one we should resolve quickly. I expect the push to create new hooks will boil over soon.
Isaac
Github Notifications (Mar 27 2018 at 14:28):
brynrhodes synchronized PR #183
Github Notifications (Mar 27 2018 at 15:06):
kpshek closed PR #183
Last updated: Apr 12 2022 at 19:14 UTC
