FHIR Chat · docs / PR #181 Document prefetch token format and update ... · cds hooks/committers

Stream: cds hooks/committers

Topic: docs / PR #181 Document prefetch token format and update ...


view this post on Zulip Github Notifications (Mar 26 2018 at 07:28):

kpshek opened PR #181
from issue/151-prefetch-tokens to master

  • {{User.id}} -> {{user}}
  • {{Patient.id}} -> {{context.patientId}}

view this post on Zulip Github Notifications (Mar 26 2018 at 07:28):

kpshek review_requested PR #181

view this post on Zulip Github Notifications (Mar 26 2018 at 07:28):

kpshek review_requested PR #181

view this post on Zulip Github Notifications (Mar 26 2018 at 15:26):

isaacvetter review_requested PR #181

view this post on Zulip Github Notifications (Mar 26 2018 at 15:43):

isaacvetter commented on PR #181

Hey Kevin,

There was some brief conversation about this notion in PR #109.

+The prefetch tokens defined by this example-hook would be {{context.patientId}} and {{context.medication.medicationId}}.

How far down into a json object is this path syntax intended to support? Note that we're also sidestepping repeating objects.

Why not only allow top-level strings to be referenced in context ?

Isaac

view this post on Zulip Github Notifications (Mar 26 2018 at 17:11):

kpshek synchronized PR #181

view this post on Zulip Github Notifications (Mar 26 2018 at 17:39):

kpshek synchronized PR #181

view this post on Zulip Github Notifications (Mar 26 2018 at 17:43):

kpshek commented on PR #181

Thanks @isaacvetter & @brynrhodes -- Your feedback has been applied in c6c2a14

view this post on Zulip Github Notifications (Mar 26 2018 at 17:44):

kpshek synchronized PR #181

view this post on Zulip Github Notifications (Mar 26 2018 at 17:48):

kpshek closed PR #181


Last updated: Apr 12 2022 at 19:14 UTC