FHIR Chat · docs / PR #145 Prefetch clarifications - Rework of PR #132 · cds hooks/committers

Stream: cds hooks/committers

Topic: docs / PR #145 Prefetch clarifications - Rework of PR #132


view this post on Zulip Github Notifications (Jan 25 2018 at 05:49):

kpshek opened PR #145
from prefetch-clarifications-rework to master

While attempting to resolve conflicts between #132 and #136 on PR #132, I made a mess of things. Rather than try and correct the serious of merge mistakes, and given that the changes were on @bakerdb's fork which I don't have access to, I decided to create a clean PR of the proposed changes from @bakerdb.

view this post on Zulip Github Notifications (Jan 25 2018 at 05:57):

kpshek commented on PR #145

Just so everyone is clear, these changes take commits from 940216 and d076fda on PR #132 as well as the changes from PR #136. The original merge conflicts were caused by some of the initial changes in PR #132 subsequently being removed completely when the changes from #136 were made.

This PR takes #136 (latest) as a base and then applies the changes from #132 where the content was still applicable.

@bakerdb - Can you give your verbal approval on the changes in this PR?

view this post on Zulip Github Notifications (Jan 25 2018 at 05:57):

kpshek review_requested PR #145

view this post on Zulip Github Notifications (Jan 27 2018 at 14:55):

kpshek commented on PR #145

Abandoning this PR as it has been superseded by PRs #146, #147, #148, #149, and #150

view this post on Zulip Github Notifications (Jan 27 2018 at 14:55):

kpshek closed PR #145


Last updated: Apr 12 2022 at 19:14 UTC