Stream: crucible
Topic: Test case bugs
Toby Hu (May 30 2018 at 19:17):
Hi @Jason Walonoski and @Robert Scanlon , there seems to be a few bugs in the test resources in crucible test suites:
- In X010: Appointment: Create New Message, the field "reason" is of 0..* carnality, so a pair of square brackets are missing.
- In X010 Claim: Create New, item.category, item.detail.category, item.detail.subDetail.category and item.detail.subDetail.service should be CodeableConcepts, but the sub fields are not conformant.
- In X010: AdverseEvent: Create New, there are no such fields as "kind" and "event"
- In X010: ClaimResponse: Create New adjudication.category fields should be CodeableConcept.
There are similar syntax errors for EpisodeOfCare, ImagingManifest, MedicationDispense and StructureDefinition resources.
Please take a look if they do look like bugs in your test cases. Thanks a lot.
Elkhan Yusubov (Oct 15 2019 at 15:06):
@Jason Walonoski & @Robert Scanlon - found another bug in test setup for Clinical resources => Resource Test Care Plan:
Setup of test has CarePlan resource payload has kind property set to invalid value set: "kind": "Group",
According to R4 spec on CarePlan it needs be one of the following: http://hl7.org/fhir/valueset-care-plan-activity-kind.html
Robert Scanlon (Oct 15 2019 at 19:29):
I'm having trouble finding that error. Did you run that on the public projectcrucible.org site or are you running a local instance?
Elkhan Yusubov (Oct 16 2019 at 14:23):
Yes, that is correct. It was run on the public projectcrucible.org.
Robert Scanlon (Oct 16 2019 at 19:18):
Do you have a link to the specific example? When looking at a result, there is a "Test Result Permalink" which saves a direct link to the result to your clipboard that you can share.
Elkhan Yusubov (Oct 16 2019 at 21:08):
@Robert Scanlon here is the link: https://projectcrucible.org/servers/5d9f940704ebd0731c000002#5da7834b04ebd05204000000/resourcetest_careplan/X010_CarePlan
Robert Scanlon (Oct 17 2019 at 15:11):
Thanks! @Jason Walonoski looks like our CarePlan resource mysteriously includes a single code outside of the ValueSet binding (directive isn't in http://hl7.org/fhir/ValueSet/care-plan-intent|4.0.0). I didn't find any obvious culprit (e.g. incorrect data in expansions.json) See https://github.com/fhir-crucible/fhir_models/blob/6a68c2787159576311eccf186bc5c21b28add4e8/lib/fhir_models/fhir/resources/CarePlan.rb#L24 and https://www.hl7.org/fhir/valueset-care-plan-intent.html
Jason Walonoski (Oct 17 2019 at 16:47):
It looks like it is being incorrectly imported from here: https://www.hl7.org/fhir/codesystem-request-intent.html which that ValueSet compose.include's from.
Jason Walonoski (Oct 17 2019 at 20:11):
Fix pending: https://github.com/fhir-crucible/fhir_models/pull/66
Elkhan Yusubov (Oct 18 2019 at 13:01):
Thanks @Jason Walonoski looking into it, let me know when it is ready to be tested. Will gladly provide support.
Last updated: Apr 12 2022 at 19:14 UTC
