Stream: crucible
Topic: Crucible complains about missing e-tag
Florian Apolloner (Jan 28 2021 at 19:06):
I have this test that rather confuses me https://projectcrucible.org/servers/601306c804ebd05f4d000001#601309b204ebd05f4d000012/readtest/R001
According to the crucible requests that got executed it just executed one search request and not trying to get a patient by ID. I also do not see it creating one before? Any tips?
Robert Scanlon (Jan 28 2021 at 19:15):
It looks like the test has a bug in it. In the setup, it is supposed to search first, then try to create a new patient resource if no patients exist. But it looks like the create code is a little off, so it isn't sending the create request to your server. https://github.com/fhir-crucible/plan_executor/blob/master/lib/tests/suites/read_test.rb#L26
Florian Apolloner (Jan 28 2021 at 19:22):
Yupp, that seems correct, I see no creation request on the server.
Florian Apolloner (Jan 28 2021 at 19:24):
How would I go about reporting? Open an issue on that repo? Sadly I do not understand ruby enough to fix that :)
Florian Apolloner (Jan 28 2021 at 19:26):
Oh it seems as if there is a fix https://github.com/fhir-crucible/plan_executor/pull/190/files -- it would need merging :)
Robert Scanlon (Jan 29 2021 at 03:13):
Thanks for looking into it and pointing out that PR. I tested it out and it works -- It's merged now but not yet deployed, I'll update here when we get a chance to do that. Thanks!
Robert Scanlon (Jan 29 2021 at 16:30):
Deployed, and I reran the test on your server and the test behavior makes a bit more sense now. Thanks again! https://projectcrucible.org/servers/601306c804ebd05f4d000001#6014371f04ebd039cb000000/readtest/R001
Florian Apolloner (Jan 30 2021 at 17:03):
That's great, thank you very much for the fast turnaround.
Last updated: Apr 12 2022 at 19:14 UTC
