Stream: terminology
Topic: in ValueSet definied designation not rendered in IG Publi...
Nikola Tanjga (Dec 27 2021 at 05:50):
Hi guys, we're trying to publish some of our ValueSets in a first HL7-Austria FHIR-Ballot and i came cross the problem that valueset designations are not beeing rendered by the IG-Publisher. I know that it is allowed to add designations not known in the codesystem. How have other here solved this? I'm happy for any hint.
Grahame Grieve (Dec 27 2021 at 19:06):
I thought they would be - where's an example?
Nikola Tanjga (Dec 28 2021 at 07:14):
Here's an example: https://fhir.hl7.at/r4-core-testing-better-valueset-expand-group-design/ValueSet-at-elga-vs-religion.html
It's a testing branch with a valueset where once i added a designation in the CLD and once to the expansion, both time to the second last code (strg+f for "Konfessionslos").
The fsh file can be found here: https://github.com/HL7Austria/HL7-AT-FHIR-Core-R4/blob/testing-better-valueset-expand-group-design/input/fsh/at-elga-vs-religion.fsh
Grahame Grieve (Jan 06 2022 at 02:57):
umm, I don't see any designations in there?
Nikola Tanjga (Jan 10 2022 at 15:23):
I deleted all other lines and only left the three concepts with their test-designations: https://fhir.hl7.at/r4-core-testing-better-valueset-expand-group-design/ValueSet-at-elga-vs-religion.html and the corresponding fsh: https://github.com/HL7Austria/HL7-AT-FHIR-Core-R4/blob/testing-better-valueset-expand-group-design/input/fsh/at-elga-vs-religion.fsh
Now it should be easy to see.
Nikola Tanjga (Jan 11 2022 at 06:00):
Could somebody send us a with the IG Publisher rendered ValueSet including designations? Thank you!
Lloyd McKenzie (Jan 11 2022 at 15:11):
You mean something like this? https://build.fhir.org/ig/HL7/sdc/ValueSet-species.html
Nikola Tanjga (Jan 11 2022 at 15:19):
Thank you for joining our discussion! Sadly no designations in this valueset (https://build.fhir.org/ig/HL7/sdc/ValueSet-species.xml.html) are being defined. This is also only possible, if the concepts are specificly included, not by a property filter. We are really looking desperatly for a IG Publisher rendered ValueSet with designations.
Grahame Grieve (Jan 14 2022 at 03:33):
as of the release after this one:
Grahame Grieve (Jan 14 2022 at 03:33):
Grahame Grieve (Jan 14 2022 at 03:49):
@Nikola Tanjga this should meet your requirements. Let me know if you think there's further improvements that you would like. (btw, 'mg' is not a FSN, but I assume that's your testing data)
Grahame Grieve (Jan 14 2022 at 04:04):
btw your expand rules extension is in the wrong place - should be on the compose not the include
Grahame Grieve (Jan 14 2022 at 04:04):
no. whoops. my mistake
Nikola Tanjga (Jan 21 2022 at 07:03):
Grahame Grieve said:
btw your expand rules extension is in the wrong place - should be on the compose not the include
Thank you for the quick solution!
Two questions are left:
- Speaking of expand rules, will the designations additionally be shown in the expansion? Also with the here used hierarchy extension?
- And, we often do have a CLD with "Include all codes from SomeCodeSystem" where it does not list all codes in the CLD. Would than the (maybe handmade/extra programmed) expansion show the designations, that are coming from the CodeSystem and are specificly needed in this ValueSet?
Thank you again for your help!
Grahame Grieve (Jan 27 2022 at 05:55):
in case #1, the designations should be shown in the expansion yes. @Nikola Tanjga
in case #2... the designations should be in the expansion, yes
Nikola Tanjga (Jan 27 2022 at 07:36):
Grahame Grieve said:
in case #1, the designations should be shown in the expansion yes. Nikola Tanjga
in case #2... the designations should be in the expansion, yes
Thank you for the answer! @Grahame Grieve
Then there is somewhere a bug for the designations in the expansions, see https://fhir.hl7.at/r4-core-testing-better-valueset-expand-group-design/ValueSet-at-elga-vs-religion.html and it's xml, or maybe i made somewhere a mistake in https://github.com/HL7Austria/HL7-AT-FHIR-Core-R4/blob/testing-better-valueset-expand-group-design/input/fsh/at-elga-vs-religion.fsh
Grahame Grieve (Jan 28 2022 at 02:28):
in fact, no, designations are not populated in expansions by default. You can configure that though. See http://hl7.org/fhir/valueset-operation-expand.html first, and then you create a json file which is a parameters file that specifies the additional parameters to the $expand operation when the IG publisher calls it, and then use the path-expansion-params parameter (https://confluence.hl7.org/display/FHIR/Implementation+Guide+Parameters) to register the expansion parameters with the IG publisher
Nikola Tanjga (Feb 03 2022 at 07:48):
If we would use the expand-operation like you said, we would lose the hierarchy, because the IG publisher can't build that with the extensions (or is that also possible now?). We are right now creating the expansion beforehand directly in the fsh file. The IG publisher never uses the expand operation in our cases (see my examples above).
So, the main question is: is there a way that the IG publisher takes the predefined expansion with its designations and renders them?
Grahame Grieve (Feb 03 2022 at 20:42):
I thought it builds hierarchically now?
Grahame Grieve (Feb 03 2022 at 20:42):
I know I programmed that somewhere
Grahame Grieve (Feb 03 2022 at 20:45):
looking at the value set renderer (org.hl7.fhir.r5.renderers.ValueSetRenderer). it only renders languages from the designations when rendering an expansion. Someone - me when I get a chance - needs to go through and change the code render other designations as well.
Nikola Tanjga (Mar 15 2022 at 08:25):
Hi @Grahame Grieve, we are unfortunately depending on the rendering of designations other than these with languages. We tried many workarounds, like one with supplements, but they never fit our needs fully. Btw: do you plan of putting them in the logical definition or expansion?
Is there somewhere a timeline or can we help or somehow co-develop?
Nikola Tanjga (Mar 29 2022 at 04:46):
Grahame Grieve said:
looking at the value set renderer (org.hl7.fhir.r5.renderers.ValueSetRenderer). it only renders languages from the designations when rendering an expansion. Someone - me when I get a chance - needs to go through and change the code render other designations as well.
Hi, me again. Asking again, if there is a timeline or can we help or somehow co-develop?
Rob Hausam (Mar 29 2022 at 10:04):
@Nikola Tanjga I'm sure that a pull request to update/fix this would be very welcome.
Grahame Grieve (Mar 30 2022 at 00:45):
you could also aim lower and submit a narrative rendering test to test cases, since that would be necessary anyway
Gabriel Kleinoscheg (Apr 08 2022 at 11:42):
Pull request created: https://github.com/hapifhir/org.hl7.fhir.core/pull/784
Gabriel Kleinoscheg (Apr 08 2022 at 11:43):
Please do also consider a related pull request: https://github.com/hapifhir/org.hl7.fhir.core/pull/783
Last updated: Apr 12 2022 at 19:14 UTC
