FHIR Chat · corrections for CG terminologsy URIs · terminology

Stream: terminology

Topic: corrections for CG terminologsy URIs


view this post on Zulip Patrick Werner (Nov 04 2018 at 11:49):

The CG WG reviewed the URIs of Genomic Terminologies in core recently and found some corrections:
GF#19611
corresponding PR: https://github.com/HL7/fhir/pull/226

The biggest change is the correction of the REFSEQ URI which was wrong/misleading until now. It would be nice to be able to include these corrections into R4.

view this post on Zulip Andrew Patterson (Nov 04 2018 at 21:36):

Why has one of the NLM URIs been changed to https? (I understand why the underlying URL for the source of data might be a https, but I thought in general all the code system URIs were left as http)

view this post on Zulip Patrick Werner (Nov 04 2018 at 23:08):

good catch, thanks. This was a copy & paste mistake. I agree with setting the URI to https, i changed it to http.
The important correction was from http://www.ncbi.nlm.nih.gov/nuccore/ to the correct: http://www.ncbi.nlm.nih.gov/refseq/

view this post on Zulip Grahame Grieve (Nov 06 2018 at 06:02):

It would be nice to be able to include these corrections into R4.

What is needed for that?

view this post on Zulip Patrick Werner (Nov 06 2018 at 08:41):

The approvement of my PR by a Vocab comitter. @Rob Hausam ?

view this post on Zulip Rob Hausam (Nov 06 2018 at 14:28):

I'll look at it, @Patrick Werner.

view this post on Zulip Patrick Werner (Sep 13 2019 at 17:22):

unfortunately some trailings slashes were introduced by my PR, sorry for that. This now leads sometimes to confusion during validation of resources.
just created GF#24110.
@Rob Hausam @Grahame Grieve any chances to get this into R4 technical corrections?

view this post on Zulip Rob Hausam (Sep 13 2019 at 21:53):

I'll defer to Grahame on the technical correction

view this post on Zulip Grahame Grieve (Sep 14 2019 at 10:32):

I can make it in the technical correction if vocab approve it for the technical correction this week

view this post on Zulip Patrick Werner (Sep 14 2019 at 18:47):

@Rob Hausam , as we just spoke. Here is the tracker item again: GF#24110
As soon as you know in which quarter this will be discussed i'll try to be there. The issue is very basic, we just want to get rid of all trailing slashes of the genetic codesystem URIs on the terminology page of core.

view this post on Zulip Patrick Werner (Sep 26 2019 at 20:25):

following up onto this issue and the proposed resolution in GF#24110.
I haven't got any negative feedback upon the proposed technical correction changes to Genetic CodeSystem URIS in R4. As all known implementers to the CG WG are using the IG as their guiding source, which never included the wrong format, this change doesn't impact any existing implementers.
The change was announced on the #Announcements #implementers #genomics streams. Also on the FHIR and Clinical Genomics mailing list. The change was also announced by @Grahame Grieve on the https://onfhir.hl7.org/2019/09/21/product-director-report-for-atlanta-sept-2019/

view this post on Zulip Patrick Werner (Sep 26 2019 at 20:28):

Notifications about the change are documented here: https://docs.google.com/document/d/17IUSdGRE_a9YS2rOID9J-sYIag3BGmyefaO10ow47RI/edit?usp=sharing

view this post on Zulip Patrick Werner (Sep 26 2019 at 20:29):

@Ted Klein @Heather Grain @Rob Hausam @Russ Hamm @Robert McClure @Carol Macumber @Reuben Daniels

view this post on Zulip Rob Hausam (Sep 26 2019 at 20:32):

we're talking about it on the Vocab call right now if you would like to join

view this post on Zulip Grahame Grieve (Sep 26 2019 at 22:58):

I also asked for what feedback I could.

view this post on Zulip Grahame Grieve (Sep 26 2019 at 22:58):

what was the outcome?

view this post on Zulip Patrick Werner (Sep 27 2019 at 08:49):

we're talking about it on the Vocab call right now if you would like to join

sorry didn't saw the response. Thanks for giving this topic time yesterday.
@Grahame Grieve according to the minutes: https://confluence.hl7.org/pages/viewpage.action?pageId=66921288 the feedback was voted on: Vote: 7/0/0, motion carries unanimously.


Last updated: Apr 12 2022 at 19:14 UTC