FHIR Chat · ValueSet Filter Operators · terminology

Stream: terminology

Topic: ValueSet Filter Operators


view this post on Zulip Peter Jordan (Aug 25 2019 at 21:53):

Looking at the table of filter operators here...http://hl7.org/fhir/valueset-filter-operator.html...
I'm wondering if something like
ValueSet.FilterComponent { Property = "display", Op = FilterOperator.In, Value = "term1,term2,term3" }
could be used to perform text matching on concept descriptions, or whether one has to use FilterOperation.regex to do this in Intensional ValueSet definitions?

view this post on Zulip Grahame Grieve (Aug 25 2019 at 22:18):

could be used.

view this post on Zulip Michael Lawley (Aug 26 2019 at 02:29):

I think this would be a much better approach. Having to support regex for this is not great, not to mention there's no specific regex flavour that's called out

view this post on Zulip Brian Postlethwaite (Aug 26 2019 at 09:02):

Can a "," be in a code value?

view this post on Zulip Peter Jordan (Aug 26 2019 at 09:45):

ValueSet.compose.filter.value is a string that, if the operator = In, can hold a comma separated list of codes or concepts.

view this post on Zulip Robert McClure (Aug 26 2019 at 12:51):

@Brian Postlethwaite raises an important consideration because "," absolutely is in concept description values. How do we manage that?

view this post on Zulip Robert McClure (Aug 26 2019 at 13:12):

We need to clarify how to do this when concept descriptions include commas: For example, the code system that started all this that I'm trying to work with - US NUCC Provider Taxonomy - is already a bit of a mess with no officially designated fully published description. It is made up of a hierarchically crafted meaning. NUCC had indicated that we could concatenate the hierarchy pieces together using ";" and "," but even that is incomplete because the hierarchical phrases also include commas. VSAC has followed the suggested approach and also variably surrounded parts that have embedded commas with quotes. So for example 364SX0204X has the description Physician Assistants & Advanced Practice Nursing Providers; Clinical Nurse Specialist, "Oncology, Pediatrics"

view this post on Zulip Grahame Grieve (Aug 26 2019 at 13:16):

have you looked at this, which is what the tools are currently using: https://github.com/FHIR/packages/blob/master/fhir.tx.support/fhir.tx.support.r4/package/CodeSystem-nucc-provider-taxonomy.json

view this post on Zulip Grahame Grieve (Aug 26 2019 at 13:18):

commas have no meaning in regex... could differentiate one whether they are escaped or not but that's ugly

view this post on Zulip Robert McClure (Aug 26 2019 at 14:09):

@Grahame Grieve No, I had not looked at it but based on the approach I just noted, that representation is not displaying the correct description for the code. Here is the way we've decided (based on a conversation with NUCC that I'll be honest, needs to be re-affirmed, but it's what VSAC is doing) to create a description for each code: It is a concatenation of each of the following to the level that is populated: the Grouping phrase followed by “; ”, then the Classification phrase. If there is a Specialization, concatenate “, ” and the Specialization phrase. For any phrase that includes a comma, wrap the phrase with standard double quotes: "

Honestly, I'd also like the code system representation to include properties for each of Grouping, Classification, and Specialization. Eventually they will hopefully create codes for the Grouping concepts, but that is not true yet. They also need to capture the hierarchy within the code system. These last two additions are interesting examples of something we could add as a code system supplement if they will not do it themselves.

@Peter Jordan has crafted a first pass at the code system but I missed telling him about the need for quotes, so it needs to be updated.

view this post on Zulip Grahame Grieve (Aug 26 2019 at 19:03):

@Peter Jordan can you make a PR against that one then?

view this post on Zulip Peter Jordan (Aug 26 2019 at 20:34):

I don't believe that the double-quotes are actually part of these concept descriptions - just the standard way of handling text strings that contain commas within a comma-delimited text file. Attempting to use an in filter to perform text matching on display values that contain commas and wishing to use a comma in the filter value (other than as a separator)...hmm, anyone who really needs to do that might require a regex operator?


Last updated: Apr 12 2022 at 19:14 UTC