FHIR Chat · Medication Status CodeSystem · terminology

Stream: terminology

Topic: Medication Status CodeSystem


view this post on Zulip Brian Postlethwaite (Nov 03 2018 at 11:33):

While I'm reviewing the technical artifacts, is it a problem that the canonicalURI for the Medication Status CODE SYSTEM has ValueSet in it? http://build.fhir.org/codesystem-medication-statement-status.html
This was changed since the Sept Ballot version, where it was http://hl7.org/fhir/medication-statement-status
(I also asked this question in the committers stream)

view this post on Zulip Brian Postlethwaite (Nov 03 2018 at 11:34):

Effect is the canonicalURI is the same for both the CodeSystem and the ValueSet

view this post on Zulip Michael Lawley (Nov 03 2018 at 11:47):

CodeSystem and ValueSet are not allowed to have the same URI

view this post on Zulip Brian Postlethwaite (Nov 03 2018 at 11:48):

Sounds like we might need a technical correction for this one then.

view this post on Zulip Lloyd McKenzie (Nov 03 2018 at 14:36):

The tooling is supposed to pick up on errors like that. @Grahame Grieve ?

view this post on Zulip Grahame Grieve (Nov 03 2018 at 19:33):

I don’t know why it hasn’t. A very serious techical error. Has someone fixed this?

view this post on Zulip Brian Postlethwaite (Nov 05 2018 at 01:24):

Ping

view this post on Zulip Rob Hausam (Nov 05 2018 at 05:28):

I assume that Pharmacy WG will see about fixing this?

view this post on Zulip Lloyd McKenzie (Nov 05 2018 at 12:51):

@Melva Peters ?

view this post on Zulip Melva Peters (Nov 05 2018 at 16:43):

I will get this fixed.

view this post on Zulip Melva Peters (Nov 05 2018 at 16:43):

@Grahame Grieve can this be fixed now?

view this post on Zulip Melva Peters (Nov 05 2018 at 19:11):

@Grahame Grieve
I have fixed the issue with the canonical status uri and did a pull request which is ready to merge. I wasn't sure if I should be merging it at this point. I'm heading out on a trip early tomorrow morning. Can you merge this in, assuming it is okay to merge?

view this post on Zulip Brian Postlethwaite (Nov 05 2018 at 22:06):

Thanks, looks like this was merged I to master, I'll check it a little later today.

view this post on Zulip Brian Postlethwaite (Nov 06 2018 at 03:05):

Yep, it has resolved my issue with code generations, however there is a misspelling Admninistration is in the name/title for several of the ValueSet/CodeSystem resources in medications.

  • medication-admin-status
  • med-admin-perform-function
  • medication-admin-category
    Its not urgent, but since you've already fixed the other, the spelling should probably be done too.

view this post on Zulip Melva Peters (Nov 06 2018 at 04:49):

I'll create a tracker and fix.

view this post on Zulip Grahame Grieve (Nov 06 2018 at 06:23):

thanks for fixing. (btw it was mandatory to fix the URL - I would have had to further down the track)

view this post on Zulip Brian Postlethwaite (Nov 06 2018 at 11:08):

http://build.fhir.org/codesystem-medication-statement-status.html
Is still showing the Canonical with the ValueSet name in the URL - I thought this was updated?

view this post on Zulip Brian Postlethwaite (Nov 06 2018 at 11:14):

I see, its in the pull request Melva still has open, are you going to approve that one @Melva Peters ?

view this post on Zulip Melva Peters (Nov 06 2018 at 12:54):

I thought both had been merged. Can you check again? If it is still an issue, I'll have to look again. I thought I had fixed. I'm just about to board a flight and won't be able to check again until mid afternoon Eastern time.

view this post on Zulip Brian Postlethwaite (Dec 06 2018 at 06:45):

Expletive! There's another of these.
http://build.fhir.org/codesystem-medicationrequest-status.html
Can I have approval to fix this one too?
@Grahame Grieve , @Melva Peters
http://build.fhir.org/codesystem-medicationrequest-intent.html
(and this one too)
I'll create a fix for them both and create a pull request but not complete it until I get replies...

view this post on Zulip Grahame Grieve (Dec 06 2018 at 09:49):

what's this another of?

view this post on Zulip Brian Postlethwaite (Dec 06 2018 at 11:40):

A code system (x2) with a canonicalURI that is the same as its valueset.
See my pull request for the exact fix.

view this post on Zulip Brian Postlethwaite (Dec 06 2018 at 11:41):

The code system and value set have the same canonicalURI.

view this post on Zulip Grahame Grieve (Dec 06 2018 at 11:47):

Ah yes please fix that

view this post on Zulip Melva Peters (Dec 06 2018 at 16:45):

Okay by me, but not sure if it's okay to merge the pull request.

view this post on Zulip Rob Hausam (Dec 06 2018 at 16:56):

since Grahame already said that he agrees, I think it should be fine to merge

view this post on Zulip Grahame Grieve (Dec 06 2018 at 20:34):

yes


Last updated: Apr 12 2022 at 19:14 UTC