FHIR Chat · Error in Doco

Stream: terminology

Topic: Error in Doco

Grahame Grieve (Sep 08 2016 at 10:51):

I've just implemented the $subsumes operation, and I've discovered that there's a mistake in the spec

Grahame Grieve (Sep 08 2016 at 10:51):

GET [base]/CodeSystem/$subsumes?system=http://snomed.info/sct&codeA=3738000&codeB=235856003

Grahame Grieve (Sep 08 2016 at 10:52):

response is said to be

{
  "resourceType" : "Parameters",
  "parameter" : [
    {
    "name" : "outcome",
    "valueCode" : "subsumes"
  }
}

Grahame Grieve (Sep 08 2016 at 10:52):

but it should actually be

{
  "resourceType" : "Parameters",
  "parameter" : [
    {
    "name" : "outcome",
    "valueCode" : "subsumed-by"
  }
}

Grahame Grieve (Sep 08 2016 at 11:09):

I'm about to post a new server versio with the following changes:

Grahame Grieve (Sep 08 2016 at 11:16):

add Conformance.instantiates
support for new overriding parameters on expansion operation
support for properties in look up
add $subsumes operation

Peter Jordan (Sep 08 2016 at 11:16):

The spec says that code A is the 'sub' code and code B is the 'super' code. So the example is asking if 3738000 |viral hepatitis| is a 235856003 | disorder of the liver| - which it is, so codeA is subsumed-by codeB...and I have to correct my server tomorrow!

Grahame Grieve (Sep 08 2016 at 11:17):

the doco needs improving, that's for sure. but the only way to read it is

Grahame Grieve (Sep 08 2016 at 11:18):

code A [relatinoship] code B

Peter Jordan (Sep 08 2016 at 11:20):

Cool - are you tackling $infer. I can see a possible issue with the SNOMED Composition example in the spec. The response returns a primitive concept which does not have a severity defining relationship.

Grahame Grieve (Sep 08 2016 at 21:09):

$infer is completely up in the air - interpret the documentation as a draft to make you think

Grahame Grieve (Sep 08 2016 at 21:09):

I'm going to tackle $infer on the plane on the way over to USA

Grahame Grieve (Sep 08 2016 at 22:02):

server is actually upgraded now

Rob Hausam (Sep 08 2016 at 23:07):

great - good to catch and fix that
I don't see a tracker item for it yet?

Peter Jordan (Sep 09 2016 at 01:00):

'Up in the air'...'on the plane' - pun intended? Looking at $subsumes - your server is returning an outcome of type string, whereas the spec states that it is of type code. Are you flying ahead of the spec?