Stream: terminology
Topic: ConceptMap dependsOn ‘code’ vs. ‘value’
Rob Hausam (Mar 04 2018 at 20:01):
We would like to get some comments, today, if possible, on GF#15604. The LIVD project in OO has identified the need to represent mapping dependencies in text. The current dependsOn.code element can actually do this since its data type is string rather than code, but the documentation doesn’t indicate that is allowed. We would like to change the element name from ‘code’ to ‘value’ and update the documentation to make this more consistent and clear. The main question for today is whether there would be objection to pre-applying this substantive change in the build today before the substantive freeze deadline.
Grahame Grieve (Mar 04 2018 at 20:03):
+1 to changing the description before the deadline. I'm a little nervous about changing the name before the deadline- not sure it will get sufficient endorsement to bet on making it like this. What happens if vocab doesn't endorse it?
Rob Hausam (Mar 04 2018 at 20:12):
I think there is a very good chance that Vocab will approve it - we generally like consistency and clarity, and don’t like to put things in code elements that aren’t codes. :). If it would happen to not get approved we could pull it back in QA (a bit of a hassle, but doable). I’m interested in @Michael Lawley’s opinion, as one of the implementers most experienced with ConceptMap.
Michael Lawley (Mar 04 2018 at 21:39):
I don't have much to say about the use of text in this context because we have no experience with using/implementing dependsOn at all. However I am very much in favour of naming things accurately, so support the name change from that perspective.
Rob Hausam (Mar 05 2018 at 02:52):
So what do we think about pre-applying the element name change to 'value'?
Grahame Grieve (Mar 05 2018 at 04:05):
I guess we do it
Rob Hausam (Mar 05 2018 at 04:06):
ok - then will commit within the next few minutes
Rob Hausam (Mar 05 2018 at 04:07):
I'm finishing up with a build run right now
Grahame Grieve (Mar 05 2018 at 04:08):
k great
Grahame Grieve (Mar 05 2018 at 04:09):
are you updating all the java model code? or just for that change?
Rob Hausam (Mar 05 2018 at 04:16):
just the specific parts that I needed for that change, if that's what you are asking
so in the R4 model it's only ConceptMap.java
plus the relevant bits of the XML, JSON and RDF parsers, the 10_40, 13_40 and 30_40 converters and the NarrativeGenerator
Grahame Grieve (Mar 05 2018 at 04:19):
ok great.
Last updated: Apr 12 2022 at 19:14 UTC
