Stream: genomics
Topic: QA for MolecularSequence
Kevin Power (Nov 28 2018 at 15:04):
There are some comments in the following document: https://drive.google.com/file/d/1Z5V562fMU2eYOymEKiyRN8KM9jMXyIcq/view?usp=sharing -- anyone have time to address the recommended changes?
Jamie Jones (Nov 28 2018 at 17:19):
All the proposed changes look good to me--they address inconsistent capitalization and punctuation, and optionally add a header for "Background and Context", which I think increases readability.
Patrick Werner (Nov 28 2018 at 17:27):
i can do this. But i didn't see the eader for "Background and Context" at first glance
Kevin Power (Nov 28 2018 at 17:43):
@James Jones can you reference where your Background and Context comment came from?
Jamie Jones (Nov 28 2018 at 17:45):
Jamie Jones (Nov 28 2018 at 17:46):
Had to open it in word to see the comment
Kevin Power (Nov 28 2018 at 17:55):
Ahh, tricky. Thanks for pointing it out. @Patrick Werner - Seems like there is a section commented out for Background and Context in the "source\molecularsequence\molecularsequence-introduction.xml" file.
Patrick Werner (Nov 28 2018 at 17:55):
i'll have a look
Patrick Werner (Nov 28 2018 at 18:10):
I applied everything, is there a tracker item for the QA Correction?
Kevin Power (Nov 28 2018 at 18:11):
No, but I think that is OK. Make sure to reference the QA document to indicate why we made the changes. Thanks Patrick!
Patrick Werner (Nov 28 2018 at 18:12):
i also checked the last comment about Background and Context. This comment contains the commented out part of the XML (end of introduction + beginning of notes.xml. I assume this was done by the QA doc creator to include all comments.
Patrick Werner (Nov 28 2018 at 18:14):
https://github.com/HL7/fhir/pull/312
Kevin Power (Nov 28 2018 at 18:24):
@Patrick Werner - Assuming you saw the build error:
2018-11-28T18:15:27.1323354Z [java] FHIR build failure @ Wed, Nov 28, 2018 18:15+0000 0.103 5sec 717MB
2018-11-28T18:15:27.1324651Z [java] Error: The spreadsheet /home/ubuntu/agents/01/_work/6/s/source/molecularsequence/molecularsequence-spreadsheet.xml was committed after editing in excel, but before the build could run after Excel was closed
2018-11-28T18:15:27.1325370Z [java] org.hl7.fhir.exceptions.FHIRException: The spreadsheet /home/ubuntu/agents/01/_work/6/s/source/molecularsequence/molecularsequence-spreadsheet.xml was committed after editing in excel, but before the build could run after Excel was closed
Patrick Werner (Nov 28 2018 at 18:25):
yes ;-) already fixed it and pushed again
Kevin Power (Nov 28 2018 at 18:25):
Excellent, thanks.
Last updated: Apr 12 2022 at 19:14 UTC
