Stream: fmg
Topic: R4B security updates
John Moehrke (Feb 09 2022 at 23:03):
I have completed the pull-request for R4B https://github.com/HL7/fhir/pull/1693
But, I get a message that there are conflicts that need to be resolved. No idea how?
It built for me, and the security pages all worked.
John Moehrke (Feb 09 2022 at 23:04):
wait... I must have not done the pull-request right, as it looks to be against master.
John Moehrke (Feb 09 2022 at 23:08):
help! I guess I don't know how to make a pull-request against R4B... my changes were in the R4B branch on my machine.
Josh Mandel (Feb 09 2022 at 23:44):
I've changed the base for you @John Moehrke. (FYI, to accomplish this I hit "edit" next to the PR title and then chose a new base -- screenshot below.)
image.png
You can see this in the PR log:
image.png
John Moehrke (Feb 10 2022 at 00:34):
thanks. i tried the edit, but when I saw that it seemed to be title edit, i stopped.
John Moehrke (Feb 10 2022 at 00:34):
merged.
John Moehrke (Feb 10 2022 at 00:35):
@Lloyd McKenzie what do I need to do with jira?
Lloyd McKenzie (Feb 10 2022 at 02:04):
Sorry - what do you need to do with Jira to do what?
Lloyd McKenzie (Feb 10 2022 at 02:04):
Oh, right. To add the groupings.
Lloyd McKenzie (Feb 10 2022 at 02:05):
You should be able to see a workflow action to modify groupings. Just add R4B.
John Moehrke (Feb 10 2022 at 13:50):
I see that. Should I put R5 and R4B? These have been applied to R5. or is it clear they were already applied to R5, and this grouping tag is just adding the R4B?
Lloyd McKenzie (Feb 10 2022 at 16:00):
R5 is presumed default. We add the R4B tag if something is R4B-relevant
John Moehrke (Feb 10 2022 at 16:46):
okay. thanks
Last updated: Apr 12 2022 at 19:14 UTC
