Stream: clinFHIR
Topic: ValueSet Editor
David Hay (May 31 2016 at 00:16):
For those interested - a simple ValueSet editor: https://fhirblog.com/2016/05/30/valueset-editor-in-clinfhir/
Erich Schulz (May 31 2016 at 00:55):
i'm definitely interested. haven't start looking hard at terminology tooling yet
Erich Schulz (May 31 2016 at 02:44):
couple of glitches and suggestions @David Hay - where would you like them?
David Hay (May 31 2016 at 02:48):
here would be just fine - any comments welcomed! (especially bug reports :) )
Erich Schulz (May 31 2016 at 02:49):
cool
Erich Schulz (May 31 2016 at 02:49):
looks really useful
Erich Schulz (May 31 2016 at 02:50):
add is-a confused me for a bit - ? would "add entire branch" be better?
Erich Schulz (May 31 2016 at 02:50):
or at least putting a title tag on the button?
Erich Schulz (May 31 2016 at 02:51):
also i was deliberately naughty and named my set Erich's test which probably caused most of my other glitches...
David Hay (May 31 2016 at 02:51):
I got the name from the terminology - but 'branch' does make more sense to the non-technical user... Perhaps call it 'branch' with a popover that describes what it does?
David Hay (May 31 2016 at 02:51):
I see I shall have to get sterner with my validation 
Erich Schulz (May 31 2016 at 02:52):
sounds good
Peter Jordan (May 31 2016 at 02:53):
In the SNOMED CT world the terms 'supertype' and 'subtype' are commonly used. When trying to add concepts to a value set manually, after query, I can't see the Add buttons in either IE11 or Chrome.
David Hay (May 31 2016 at 02:56):
Wierd. what happens if you re-load the page and just click 'new'?
David Hay (May 31 2016 at 02:57):
Oh - and you are using Grahames server?
Peter Jordan (May 31 2016 at 02:58):
I'm using Grahame's server and will try that after my next meeting. I could see the HTML for the buttons when I viewed source.
David Hay (May 31 2016 at 03:02):
Thanks for testing! It's only a weekend old, so will doubtless have many issues. I use the ng-show / ng-hide a lot, so just seeing the html in the page doesn't necessarily mean it's visible...
David Hay (May 31 2016 at 03:03):
Oh - and don;t forget that you can't change one of the existing valuesets - you can copy one and then edit it, or create one from scratch (preferred) - otherwise it will be read-only
Erich Schulz (May 31 2016 at 03:05):
I keep losing my set @David Hay !
Erich Schulz (May 31 2016 at 03:06):
is it supposed to persist?
David Hay (May 31 2016 at 03:06):
you mean you save it and then can't find it?
Erich Schulz (May 31 2016 at 03:07):
yes
David Hay (May 31 2016 at 03:07):
what name are you using?
Erich Schulz (May 31 2016 at 03:08):
mmm
Erich Schulz (May 31 2016 at 03:08):
maybe it was just the apostrophe
David Hay (May 31 2016 at 03:08):
It sets the name property of the valueset to the name you enter, and then you should be able to search on that...
David Hay (May 31 2016 at 03:09):
yes, please start with single words and see if that works and move on form there. I suspect an apostrophe will confuse it...
Erich Schulz (May 31 2016 at 03:10):
ok i'm good
Erich Schulz (May 31 2016 at 03:10):
its ok with Erich-test
David Hay (May 31 2016 at 03:11):
whew! I'll beef up the validation as it's an easy mistake to make...
Erich Schulz (May 31 2016 at 03:12):
omg snomed is awful
Erich Schulz (May 31 2016 at 03:13):
http://www.clipular.com/c/4842662449905664.png?k=ekB1kAiHNM0Dyv_O1hF-dOx_U7A
Erich Schulz (May 31 2016 at 03:13):
i mean to say the Read codes were pretty rubbish too
Erich Schulz (May 31 2016 at 03:14):
portal != arterial hypertension... sigh
David Hay (May 31 2016 at 03:19):
would be interesting to confirm the relationship in a tool like snapper to make sure it's not an artifact of the expansion on the server or the UI...
Peter Jordan (May 31 2016 at 04:04):
All works on the 'Select from binding' tab, but don't see the buttons after a lookup from the 'Enter Directly' tab.
David Hay (May 31 2016 at 04:40):
OK - I'll check that out - I must admit I've always selected from binding first, then gone across to the 'enter directly' tab so that's likely what's happenning...
Erich Schulz (May 31 2016 at 05:28):
ah @David Hay that is reassuring...
Erich Schulz (May 31 2016 at 05:28):
http://www.clipular.com/c/5636012056772608.png?k=fCgJekGlqsXof754AIXc975seUA
Erich Schulz (May 31 2016 at 05:28):
that is from CSIRO.au shrimp
Erich Schulz (May 31 2016 at 05:30):
so that means that whatever is coming from from "Grahame's server" is flaky then
Erich Schulz (May 31 2016 at 05:32):
curious about the source of flakiness so I can avoid it (hunting out or making a nice ancestor table to do roll ups is on my todo list)
David Hay (May 31 2016 at 05:38):
Interesting - I did wonder! Not too quick to blame Grahames server at the moment (in the past I've usually been the one wrong :( )
David Hay (May 31 2016 at 05:41):
In discussions with michael lawley to use ontoserver as a source (some minor niggles with CORS at the moment) - so will see if we get the same results from there (suggesting an issue with the editor) or not - suggesting an issue with Grahames server. Hopefully that will happen soon (though shortly about to board a plan to the US which will slow things down a bit!)
David Hay (May 31 2016 at 05:42):
btw @Peter Jordan - have fixed that issue with entering a code directly and tightened up the validation to deal with @Erich Schulz being difficult!
David Hay (May 31 2016 at 06:44):
btw - have added ontoserver as a source. The process is a bit convoluted right now - the following should work:
1 Navigate to http://107.170.196.80/resourceCreator.html
2. From the gear menu (upper right) select 'reset config'
3 after the message navigate to http://localhost:8000/valuesetCreator.html
4. select 'ontoserver'
5. reload the page
will tidy later...
Erich Schulz (May 31 2016 at 07:36):
heh I can be more difficult @David Hay :-)
David Hay (Jun 01 2016 at 00:35):
Now I'm really worried...
Last updated: Apr 12 2022 at 19:14 UTC
