Stream: dotnet
Topic: R5 Builds
Gino Canessa (Dec 18 2019 at 14:40):
Good morning! I have had various people asking about R5 builds of the C# API. Building myself isn't too troublesome, but building what people want is harder... Release builds require signing, so I need to either strip off code-signing or put in my own key, and Debug doesn't output the NuGet files. Was wondering if there could be a develop-r5 or nightly branch added with an automated build process (e.g., GitHub Actions, Azure Pipeline, etc.).
Happy to help if there's interest but not bandwidth to do it, but thought I'd try for 'official' before building out something separate.
Thanks!
Brian Postlethwaite (Dec 19 2019 at 11:20):
I'll have a look over the Christmas break
Marco Visser (Dec 19 2019 at 11:22):
Hi Gino,
we are in the middle of releasing version 1.5.0-beta at the moment, which wil contain the technical corrections for 3.0.2 and 4.0.1. This will be released today (20191219).
After the x-mas holidays we can create a branch for R5. We will not actively support this branch then, but on request we can update it. Maybe I can automate this with Azure Pipelines.
So keep an eye on our releases.
Happy holidays!
Gino Canessa (Dec 19 2019 at 14:42):
Thanks to each of you!
Gino Canessa (Jan 09 2020 at 20:33):
Hello Marco, and happy new year! I wanted to follow-up on an R5 build status/nightly/etc and/or if there's anything I can do. Thanks!
Brian Postlethwaite (Jan 13 2020 at 05:58):
I have a build compiling locally.
Will see if any of the tests pass before I push the new branch to git.
(want to walk through all the diffs to ensure that all the correct code has been re-generated, and haven't missed anything significant)
Brian Postlethwaite (Jan 13 2020 at 22:18):
Serialization roundtrip works on everything, except the integer64 in json, as that needs to be string type when serialized, so that will be fun tweaking that (haven't been in that part of the new codebase yet)
Brian Postlethwaite (Jan 13 2020 at 22:18):
And the structuredefinition provider isn't working, only the poco provider.
Brian Postlethwaite (Jan 13 2020 at 22:37):
This is the test FullRoundtripOfAllExamplesJsonNavPocoProvider that demonstrates the integer64 issue
Brian Postlethwaite (Jan 13 2020 at 22:41):
I've pushed the code to https://github.com/FirelyTeam/fhir-net-api/tree/feature/1.5.0-alpha1-r5 this has the above issues in it for someone else to look into. I'm not going to get any additional time to try and resolve these 2 issues ahead of the Sydney connectathon.
So if someone else can look into those, that would be awesome.
The integer64 json serialization is the main one (used in the size attribute of the annotation datatype) - unless you're needing the SD summary provider, in which case more effort needed.
@Marco Visser can you see if someone can look here, otherwise just package it up and release alpha to NuGet.
Marco Visser (Jan 14 2020 at 09:29):
Thanks Brian. Great work!
Our team will have a look at this the coming week.
Brian Postlethwaite (Jan 14 2020 at 10:02):
Thanks Marco.
Gino Canessa (Jan 14 2020 at 17:28):
Thanks a bunch!
Brian Postlethwaite (Jan 14 2020 at 21:55):
@Gino Canessa i generated to the current build.Fhir.Org definitions, so there might be some differences since Grahame did the cut off.
If that's an issue I can find the location of the branch for the connectathon and generate from that.
Gino Canessa (Jan 14 2020 at 21:58):
No worries Brian! I've been fending off requests for R5 tooling for testing, so this helps quite a bit. Appreciate it.
Grahame Grieve (Jan 14 2020 at 21:58):
you should consider using the NPM package for generation...
Brian Postlethwaite (Jan 15 2020 at 00:59):
I did consider doing that, I have the code to process it, and probably will.
But expediency to get the build out... :grinning_face_with_smiling_eyes:
Marco Visser (Jan 15 2020 at 15:03):
pasted image
Working on to solve those 40 failing unit tests
Brian Postlethwaite (Jan 15 2020 at 19:53):
I don't know if anyone has a server to test against either.
Brian Postlethwaite (Jan 15 2020 at 19:54):
So those tests are sure not to pass.
Marco Visser (Jan 16 2020 at 09:41):
Those tests against a R5 server are not executed by the buildserver.
For the other test I think I have found the problem, so hopefully I have a solution for it today.
Brian Postlethwaite (Jan 16 2020 at 22:09):
Awesome, great to hear.
Marco Visser (Jan 30 2020 at 16:11):
The alpha release of R5 has been released now: see MyGet https://www.myget.org/F/fhir-net-api/api/v3/index.json
And there is now also a R5 server to talk to: https://labs.vonk.fire.ly
Last updated: Apr 12 2022 at 19:14 UTC
