FHIR Chat · FSH Support and submodules · dotnet

Stream: dotnet

Topic: FSH Support and submodules


view this post on Zulip Gino Canessa (May 14 2020 at 18:49):

Howdy! I'm trying to add in FSH support for serializing and parsing, but it looks like the file changes span both the primary repo and the submodule. I had forked the main repo so that I could build out a PR, but I'm not familiar with submodules in this context; how should changes/PRs be handled?

Thanks!

view this post on Zulip Ewout Kramer (May 14 2020 at 19:15):

Hi Gino, I think that's going to be a bit of a pain, we did the split in two repos about a year ago, so we wont have a nice merge experience ;-) It's probably best if we take this offline.

view this post on Zulip Ewout Kramer (May 14 2020 at 19:16):

Generally, we have one repo with shared code (fhir-net-common) that is not fhir-version of POCO-related, and a repo which has a branch per fhir version (fhir-net-api). And we are moving more and more code over from the three branches, aligning them and putting them back in fhir-net-common.

view this post on Zulip Gino Canessa (May 14 2020 at 19:19):

Thanks Ewout. So would it make the most sense to get it working on my local box and then figure it out manually afterwards? E.g., look at the list of files changed and go from there?


Last updated: Apr 12 2022 at 19:14 UTC