Stream: javascript
Topic: Native FHIR.js Adapter
Cole Diffin (Apr 04 2016 at 23:46):
I've added a PR for FHIR.js to add support for browser native fetch and Promise API's https://github.com/FHIR/fhir.js/pull/61
Cole Diffin (Apr 05 2016 at 02:27):
@Josh Mandel @nicola Would appreciate a review.
Josh Mandel (Apr 05 2016 at 04:16):
Thanks @Cole Diffin -- I'm looking over this now!
Josh Mandel (Apr 05 2016 at 04:26):
Looks great to me; I made a few small comments on your PR. Thanks very much for wading through the under-documented code!
Cole Diffin (Apr 05 2016 at 04:39):
Thanks. I think i destroyed the comments by force pushing updates.... Summarised on the PR comment list.
Josh Mandel (Apr 05 2016 at 14:33):
No problem -- thanks for the contribution! I merged just after your second push.
Cole Diffin (Apr 20 2016 at 00:32):
@Josh Mandel @nicola I've found an error in my previous contributions (More of an omission) Documented here https://github.com/FHIR/fhir.js/issues/62 and PR awaiting review.
nicola (RIO/SS) (Apr 20 2016 at 09:24):
@Cole - merged. Should we release 0.0.10?
Cole Diffin (Apr 20 2016 at 09:24):
Thanks. That would be awesome.
nicola (RIO/SS) (Apr 20 2016 at 09:31):
done
Cole Diffin (Apr 20 2016 at 09:31):
Thank you very much :-)
Josh Mandel (Apr 20 2016 at 18:04):
Thanks! Please also see my comment at https://github.com/FHIR/fhir.js/issues/64 -- I'd like to ensure that cookies can be opt-in, and that the work consistently across adapters.
Last updated: Apr 12 2022 at 19:14 UTC
