Stream: hapi
Topic: hapi-fhir: pull request 293: Allow loading from local fil...
Zulip HAPI Bot (Feb 05 2016 at 19:49):
adam-carbone opened pull request 293
I have added the ability to load data zip files from a local file/directory
- If the path passed in points to a local zip file it will load the resources from inside.
- If the path points to a local directory it will look inside for zip files in that directory and load the resourcesAlso used a temporary file in the ~/.hapi-fhir-cli/cache as a temporary file for the downloaded example file, this allowed for usage of a FileInputStream instead of a ByteArrayInputStream, thus allowing us to handle bigger files because they are not loaded completely into memory.
Also provided for automatic caching of that local temp file for up to 12 hours using the -c option.
Zulip HAPI Bot (Feb 08 2016 at 15:14):
adam-carbone synchronized pull request 293
Zulip HAPI Bot (Feb 08 2016 at 20:56):
adam-carbone commented on pull request 293
Hmmmm that coverage change is talking about a class that I didn't touch... @James Agnew What can I do to fix the change?
Zulip HAPI Bot (Feb 08 2016 at 20:58):
adam-carbone commented on pull request 293
The coverage change is indicating a drop in coverage in classes that I didn't even touch, I only changed one class. @James Agnew hat can I do to help to help resolve that?
Zulip HAPI Bot (Feb 09 2016 at 03:00):
jamesagnew commented on pull request 293
The coveralls check is probably nothing. Coveralls often seems to get it wrong for pull requests, I've never figured out why.
This looks great, thanks for the contribution. Merging it now!
Zulip HAPI Bot (Feb 09 2016 at 03:00):
jamesagnew closed pull request 293
Last updated: Apr 12 2022 at 19:14 UTC
