FHIR Chat · hapi-fhir: pull request 288: Exposing parameters for HTTP... · hapi

Stream: hapi

Topic: hapi-fhir: pull request 288: Exposing parameters for HTTP...


view this post on Zulip Zulip HAPI Bot (Jan 20 2016 at 17:07):

matt-blanchette opened pull request 288

The current RestfulClientFactory uses the default HTTP client PoolingHttpClientConnectionManager settings for max number of connections.
The defaults for these are 20 max total connections and 2 max per route.

These changes expose parameters on RestfulClientFactory to allow overriding these defaults.

The default for max connections per route is also changed here from 2 to 20 (using the same value as max total connections).

Other possible approaches:
* Expose HttpClientBuilder in RestfulClientFactory, allow subclasses to override settings
* Expose a setter for IRestfulClientFactory in FhirContext to allow subclassing

view this post on Zulip Zulip HAPI Bot (Jan 22 2016 at 02:45):

jamesagnew commented on pull request 288

Thanks! This looks awesome, merging it now.

view this post on Zulip Zulip HAPI Bot (Jan 22 2016 at 02:46):

jamesagnew closed pull request 288


Last updated: Apr 12 2022 at 19:14 UTC